Skip to content

Commit a303ec1

Browse files
committed
Merge pull request #1426 from lamblin/small_fixes
Small fixes
2 parents 08a4e4a + d5aa660 commit a303ec1

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

doc/internal/pull_request_checklist.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,3 +325,8 @@ Use the `with` statement, i.e.::
325325

326326
This is cleaner and ensures that the file always gets closed, even in an
327327
error condition.
328+
329+
Are you adding new files or changing files permissions?
330+
=======================================================
331+
The files containing unit tests (named `test_....py`) should never be
332+
executable, otherwise nose will ignore them, and not execute the tests.

pylearn2/scripts/papers/maxout/compute_test_err.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ def accs():
5151
data_specs = model.cost_from_X_data_specs())
5252
for item in iterator:
5353
x_arg, y_arg = item
54-
if Xb.ndim > 2:
55-
x_arg = test.get_topological_view(x_arg)
5654
mf1_accs.append(batch_acc(x_arg, y_arg)[0])
5755
return sum(mf1_accs) / float(len(mf1_accs))
5856

0 commit comments

Comments
 (0)