Skip to content

Commit 0fc11f9

Browse files
kcw-gruntvsima
andauthored
πŸš€[ Release v.2.8.1] Merge into Main (#133)
* πŸ’£πŸž[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * πŸš€[ Release v.2.6.0] Merge into Develop (#13) * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> * πŸš€[Release] v2.6.1 (#21) * version code bump * πŸš€[ Release v.2.6.0] Merge into Main (#12) * Added ΡƒΠΊΡ€Π°Ρ—Π½ΡΡŒΠΊΠΈΠΉ language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * πŸ₯³[Feature] Unstoppable ext update (#11) * WIP: DNC Dropped in the UD code prior to testing * Added study link * Fix unstoppable domains dependency * Updated the UD ext text WIP::::Need to refactor once UK and deletion on SV, NL, DA * added UK lang Co-authored-by: Victor Sima <[email protected]> * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * Create ISSUE_TEMPLATE * Delete ISSUE_TEMPLATE * Create test.md * Delete test.md * πŸš€[ Release v.2.7.0] Merge into Develop (#32) * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener * [Techdebt/] pdate match firebase events 33 (#48) * Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug * Fix - revert FragmentBuy webview test (#72) * πŸš€[ Release v.2.7.1] Merge into Develop (#104) * πŸš€[ Release v.2.7.0] Merge into Main (#30) * Added ΡƒΠΊΡ€Π°Ρ—Π½ΡΡŒΠΊΠΈΠΉ language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * πŸ’£πŸž[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * πŸš€[ Release v.2.6.0] Merge into Develop (#13) * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> * πŸš€[Release] v2.6.1 (#21) * version code bump * πŸš€[ Release v.2.6.0] Merge into Main (#12) * Added ΡƒΠΊΡ€Π°Ρ—Π½ΡΡŒΠΊΠΈΠΉ language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * πŸ₯³[Feature] Unstoppable ext update (#11) * WIP: DNC Dropped in the UD code prior to testing * Added study link * Fix unstoppable domains dependency * Updated the UD ext text WIP::::Need to refactor once UK and deletion on SV, NL, DA * added UK lang Co-authored-by: Victor Sima <[email protected]> * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener Co-authored-by: Victor Sima <[email protected]> * Create FUNDING.yml For GH Sponsor * πŸ’£πŸž[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * πŸš€[ Release v.2.7.0] Merge into Develop (#32) * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener * [Techdebt/] pdate match firebase events 33 (#48) * Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug * version bump * renmoved staging * moved backup rates * code bump * Updated test configs * Move api resources to central location - version code bump Co-authored-by: Victor Sima <[email protected]> * Commented out the partial work * Add .circleci/config.yml (#74) * Feature - donation disclaimer modal (#75) * Feature - add donation modal disclaimer - #60 * Add missing strings * Upgraded AS - Reduced donation amount - Renamed id WIP * updated stirings key format - updated the donation address * code bump Co-authored-by: kcw-grunt <[email protected]> * Feature - Show Litecoin Card as Webview (#82) * Feature - Show Litecoin Card as Webview - remove partner api library - create card frament webview and add to bottom nav - fixes #58 * bump version code * Fix UI crash * bump version code Co-authored-by: kcw-grunt <[email protected]> * πŸš€[Release v.2.8.0] Merge into Develop (#124) * πŸ’£πŸž[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * Delete ISSUE_TEMPLATE * πŸš€[ Release v.2.7.0] Merge into Develop (#32) * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener * [Techdebt/] pdate match firebase events 33 (#48) * Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug * πŸš€[ Release v.2.7.1] Merge into Develop (#104) * πŸš€[ Release v.2.7.0] Merge into Main (#30) * Added ΡƒΠΊΡ€Π°Ρ—Π½ΡΡŒΠΊΠΈΠΉ language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * πŸ’£πŸž[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * πŸš€[ Release v.2.6.0] Merge into Develop (#13) * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> * πŸš€[Release] v2.6.1 (#21) * version code bump * πŸš€[ Release v.2.6.0] Merge into Main (#12) * Added ΡƒΠΊΡ€Π°Ρ—Π½ΡΡŒΠΊΠΈΠΉ language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * πŸ₯³[Feature] Unstoppable ext update (#11) * WIP: DNC Dropped in the UD code prior to testing * Added study link * Fix unstoppable domains dependency * Updated the UD ext text WIP::::Need to refactor once UK and deletion on SV, NL, DA * added UK lang Co-authored-by: Victor Sima <[email protected]> * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener Co-authored-by: Victor Sima <[email protected]> * Create FUNDING.yml For GH Sponsor * πŸ’£πŸž[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * πŸš€[ Release v.2.7.0] Merge into Develop (#32) * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener * [Techdebt/] pdate match firebase events 33 (#48) * Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug * version bump * renmoved staging * moved backup rates * code bump * Updated test configs * Move api resources to central location - version code bump Co-authored-by: Victor Sima <[email protected]> * Feature - donation disclaimer modal (#75) * Feature - add donation modal disclaimer - #60 * Add missing strings * Upgraded AS - Reduced donation amount - Renamed id WIP * updated stirings key format - updated the donation address * code bump Co-authored-by: kcw-grunt <[email protected]> * Feature - Show Litecoin Card as Webview (#82) * Feature - Show Litecoin Card as Webview - remove partner api library - create card frament webview and add to bottom nav - fixes #58 * bump version code * Fix UI crash * bump version code Co-authored-by: kcw-grunt <[email protected]> * version code bump - updated version labels to include the version code * Task - Reduce country iso exception (#118) - reduce emissions of "java.lang.IllegalArgumentException: Unsupported ISO 3166 country: en" * made the webview fileprivate (#120) - the idea is that it will help evaluate the js callbacks * Refactors version name and code to BRConstants (#121) * 🐜[Bugfix] Refactor strings files (#122) * bump version code * Refactor strings files There were many unused strings and they were removed. * bump version code * resolved bad resolution --------- Co-authored-by: Victor Sima <[email protected]> * 🐜[Bugfix] Fragment fingerprint crash 125 (#131) * Removed comments and header as a non-effecting change * Refactored by overriding onAnimation Used notes from : https://stackoverflow.com/questions/4750939/android-animation-is-not-finished-in-onanimationend There calling super.onAnimationEnd(animation) seems to resolves the crash * Clearing the layout should be valid ?? * version code and name bump * Added semi-permenant test point - No Error Nominal Response..where the crash used to be - version code bump * - remove animation logic from fragment#onStop() - remove fragment close logic from SlideDetector - clean up duplicate fragmentmanager stack pop - other small fixes --------- Co-authored-by: Victor Sima <[email protected]> * 🐜[Bugfix] Displaylistcanvas 129 (#130) * fixed broken Timber by reverting to 4.7.1 - horrible but effectuve fix: remove reference to a deleted file. use a placeholder that is tiny. The size made the difference in the Crash * version name and code bump * bump version name and code * reset to version name and code --------- Co-authored-by: Victor Sima <[email protected]>
1 parent 92807ba commit 0fc11f9

25 files changed

+220
-338
lines changed

β€Žapp/build.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ android {
6464
applicationId = 'com.loafwallet'
6565
minSdkVersion 27
6666
targetSdkVersion 32
67-
versionCode 722
68-
versionName "v2.8.0"
67+
versionCode 725
68+
versionName "v2.8.1"
6969
multiDexEnabled true
7070
archivesBaseName = "${versionName}(${versionCode})"
7171

@@ -309,7 +309,7 @@ dependencies {
309309
implementation 'com.google.firebase:firebase-crashlytics-ndk'
310310

311311
// Timber
312-
implementation 'com.jakewharton.timber:timber:5.0.1'
312+
implementation 'com.jakewharton.timber:timber:4.7.1'
313313

314314
// Unstoppable domain
315315
implementation 'com.unstoppabledomains:resolution:5.0.0'

β€Žapp/src/main/java/com/breadwallet/BreadApp.java

+2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import java.util.TimerTask;
2525
import java.util.concurrent.atomic.AtomicInteger;
2626

27+
import static timber.log.Timber.DebugTree;
28+
2729
import timber.log.Timber;
2830

2931
public class BreadApp extends Application {

β€Žapp/src/main/java/com/breadwallet/presenter/fragments/FragmentFingerprint.java

+26-42
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,4 @@
1-
package com.breadwallet.presenter.fragments;/*
2-
* Copyright (C) 2015 The Android Open Source Project
3-
*
4-
* Licensed under the Apache License, Version 2.0 (the "License");
5-
* you may not use this file except in compliance with the License.
6-
* You may obtain a copy of the License at
7-
*
8-
* http://www.apache.org/licenses/LICENSE-2.0
9-
*
10-
* Unless required by applicable law or agreed to in writing, software
11-
* distributed under the License is distributed on an "AS IS" BASIS,
12-
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13-
* See the License for the specific language governing permissions and
14-
* limitations under the License
15-
*/
1+
package com.breadwallet.presenter.fragments;
162

173
import android.animation.Animator;
184
import android.animation.AnimatorListenerAdapter;
@@ -24,7 +10,6 @@
2410
import android.hardware.fingerprint.FingerprintManager;
2511
import android.os.Bundle;
2612
import android.os.Handler;
27-
import androidx.annotation.Nullable;
2813
import android.view.LayoutInflater;
2914
import android.view.View;
3015
import android.view.ViewGroup;
@@ -36,15 +21,20 @@
3621
import android.widget.RelativeLayout;
3722
import android.widget.TextView;
3823

24+
import androidx.annotation.Nullable;
25+
3926
import com.breadwallet.R;
4027
import com.breadwallet.presenter.activities.BreadActivity;
4128
import com.breadwallet.presenter.interfaces.BRAuthCompletion;
4229
import com.breadwallet.tools.animation.BRAnimator;
4330
import com.breadwallet.tools.animation.DecelerateOvershootInterpolator;
31+
import com.breadwallet.tools.manager.AnalyticsManager;
4432
import com.breadwallet.tools.security.AuthManager;
4533
import com.breadwallet.tools.security.FingerprintUiHelper;
34+
import com.breadwallet.tools.util.BRConstants;
4635
import com.breadwallet.tools.util.Utils;
4736

37+
import timber.log.Timber;
4838

4939
/**
5040
* A dialog which uses fingerprint APIs to authenticate the user, and falls back to password
@@ -74,22 +64,18 @@ public FragmentFingerprint() {
7464
@Override
7565
public void onCreate(Bundle savedInstanceState) {
7666
super.onCreate(savedInstanceState);
77-
78-
// Do not create a new Fragment when the Activity is re-created such as orientation changes.
7967
setRetainInstance(true);
80-
// setStyle(DialogFragment.STYLE_NORMAL, android.R.style.Theme_Material_Light_Dialog);
8168
}
8269

8370
@Override
8471
public View onCreateView(LayoutInflater inflater, ViewGroup container,
8572
Bundle savedInstanceState) {
8673

87-
View v = inflater.inflate(R.layout.fingerprint_dialog_container, container, false);
88-
// getDialog().setTitle(R.string.fingerprint_auth);
89-
message = (TextView) v.findViewById(R.id.fingerprint_description);
90-
title = (TextView) v.findViewById(R.id.fingerprint_title);
91-
fingerPrintLayout = (LinearLayout) v.findViewById(R.id.fingerprint_layout);
92-
fingerprintBackground = (RelativeLayout) v.findViewById(R.id.fingerprint_background);
74+
View authModalView = inflater.inflate(R.layout.fingerprint_dialog_container, container, false);
75+
message = (TextView) authModalView.findViewById(R.id.fingerprint_description);
76+
title = (TextView) authModalView.findViewById(R.id.fingerprint_title);
77+
fingerPrintLayout = (LinearLayout) authModalView.findViewById(R.id.fingerprint_layout);
78+
fingerprintBackground = (RelativeLayout) authModalView.findViewById(R.id.fingerprint_background);
9379
Bundle bundle = getArguments();
9480
String titleString = bundle.getString("title");
9581
String messageString = bundle.getString("message");
@@ -103,21 +89,16 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
10389
}
10490
FingerprintManager mFingerprintManager = (FingerprintManager) getActivity().getSystemService(Activity.FINGERPRINT_SERVICE);
10591
mFingerprintUiHelperBuilder = new FingerprintUiHelper.FingerprintUiHelperBuilder(mFingerprintManager);
106-
mFingerprintUiHelper = mFingerprintUiHelperBuilder.build((ImageView) v.findViewById(R.id.fingerprint_icon),
107-
(TextView) v.findViewById(R.id.fingerprint_status), this, getContext());
108-
View mFingerprintContent = v.findViewById(R.id.fingerprint_container);
92+
mFingerprintUiHelper = mFingerprintUiHelperBuilder.build((ImageView) authModalView.findViewById(R.id.fingerprint_icon),
93+
(TextView) authModalView.findViewById(R.id.fingerprint_status), this, getContext());
94+
View mFingerprintContent = authModalView.findViewById(R.id.fingerprint_container);
10995

110-
Button mCancelButton = (Button) v.findViewById(R.id.cancel_button);
111-
Button mSecondDialogButton = (Button) v.findViewById(R.id.second_dialog_button);
96+
Button mCancelButton = (Button) authModalView.findViewById(R.id.cancel_button);
97+
Button mSecondDialogButton = (Button) authModalView.findViewById(R.id.second_dialog_button);
11298
mCancelButton.setOnClickListener(new View.OnClickListener() {
11399
@Override
114100
public void onClick(View view) {
115101
if (!BRAnimator.isClickAllowed()) return;
116-
// if (!BRAnimator.scanResultFragmentOn && mode == BRConstants.AUTH_FOR_PAY && request.isAmountRequested) {
117-
//// FragmentScanResult.address = request.address[0];
118-
// BRWalletManager.getInstance().offerToChangeTheAmount(getActivity(), "");
119-
// }
120-
// dismiss();
121102
closeMe();
122103
}
123104
});
@@ -133,7 +114,7 @@ public void onClick(View view) {
133114
}
134115
});
135116

136-
return v;
117+
return authModalView;
137118
}
138119

139120
@Override
@@ -156,9 +137,8 @@ public void onGlobalLayout() {
156137
@Override
157138
public void onStop() {
158139
super.onStop();
159-
160-
animateBackgroundDim(true);
161-
animateSignalSlide(true);
140+
// animateBackgroundDim(true);
141+
// animateSignalSlide(true);
162142
if (!authSucceeded)
163143
completion.onCancel();
164144
}
@@ -248,12 +228,16 @@ private void animateSignalSlide(final boolean reverse) {
248228
fingerPrintLayout.animate()
249229
.translationY(1500)
250230
.setDuration(ANIMATION_DURATION)
251-
.withLayer().setInterpolator(new AnticipateInterpolator(2f)).setListener(new AnimatorListenerAdapter() {
231+
.withLayer()
232+
.setInterpolator(new AnticipateInterpolator(2.0f))
233+
.setListener(new AnimatorListenerAdapter() {
252234
@Override
253235
public void onAnimationEnd(Animator animation) {
254236
super.onAnimationEnd(animation);
255-
if (getActivity() != null)
256-
getActivity().getFragmentManager().beginTransaction().remove(FragmentFingerprint.this).commit();
237+
if (getActivity() != null) {
238+
fingerPrintLayout.clearAnimation();
239+
AnalyticsManager.logCustomEvent(BRConstants._20230131_NENR);
240+
}
257241
}
258242
});
259243

β€Žapp/src/main/java/com/breadwallet/presenter/fragments/FragmentMenu.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public View onCreateView(LayoutInflater inflater,
5353
background.setOnClickListener(v -> {
5454
if (!BRAnimator.isClickAllowed()) return;
5555
closeMenu();
56-
getActivity().onBackPressed();
5756
});
5857

5958
itemList = new ArrayList<>();
@@ -82,21 +81,18 @@ public View onCreateView(LayoutInflater inflater,
8281
itemList.add(new BRMenuItem(getString(R.string.MenuButton_lock), R.drawable.ic_lock, v -> {
8382
closeMenu();
8483
final Activity from = getActivity();
85-
from.getFragmentManager().popBackStack();
8684
BRAnimator.startBreadActivity(from, true);
8785
}));
8886

8987
/* Close button*/
9088
rootView.findViewById(R.id.close_button).setOnClickListener(v -> {
9189
closeMenu();
92-
Activity app = getActivity();
93-
app.getFragmentManager().popBackStack();
9490
});
9591

9692
mTitle = rootView.findViewById(R.id.title);
9793
mListView = rootView.findViewById(R.id.menu_listview);
9894
mListView.setAdapter(new MenuListAdapter(getContext(), R.layout.menu_list_item, itemList));
99-
signalLayout.setOnTouchListener(new SlideDetector(getContext(), signalLayout));
95+
signalLayout.setOnTouchListener(new SlideDetector(signalLayout, this::closeMenu));
10096

10197
return rootView;
10298
}
@@ -154,7 +150,7 @@ public View getView(int position, @Nullable View convertView, @NonNull ViewGroup
154150
private void closeMenu() {
155151
BRAnimator.animateBackgroundDim(background, true);
156152
BRAnimator.animateSignalSlide(signalLayout, true, () -> {
157-
if (getActivity() != null) {
153+
if (getActivity() != null && !getActivity().isDestroyed() && !getActivity().isFinishing()) {
158154
getActivity().getFragmentManager().popBackStack();
159155
}
160156
});

β€Žapp/src/main/java/com/breadwallet/presenter/fragments/FragmentPin.java

+16-16
Original file line numberDiff line numberDiff line change
@@ -204,22 +204,22 @@ public void run() {
204204
@Override
205205
public void onStop() {
206206
super.onStop();
207-
keyboard.animate()
208-
.translationY(1000)
209-
.withLayer();
210-
dialogLayout.animate()
211-
.scaleY(0)
212-
.scaleX(0).alpha(0);
213-
mainLayout.animate().alpha(0);
214-
if (!authSucceeded)
215-
completion.onCancel();
216-
new Handler().postDelayed(new Runnable() {
217-
@Override
218-
public void run() {
219-
if (getActivity() != null)
220-
getActivity().getFragmentManager().beginTransaction().remove(FragmentPin.this).commit();
221-
}
222-
}, 1000);
207+
// keyboard.animate()
208+
// .translationY(1000)
209+
// .withLayer();
210+
// dialogLayout.animate()
211+
// .scaleY(0)
212+
// .scaleX(0).alpha(0);
213+
// mainLayout.animate().alpha(0);
214+
// if (!authSucceeded)
215+
// completion.onCancel();
216+
// new Handler().postDelayed(new Runnable() {
217+
// @Override
218+
// public void run() {
219+
// if (getActivity() != null)
220+
// getActivity().getFragmentManager().beginTransaction().remove(FragmentPin.this).commit();
221+
// }
222+
// }, 1000);
223223
}
224224

225225
public void setCompletion(BRAuthCompletion completion) {

0 commit comments

Comments
Β (0)