[BUG] Database paths/names with "=" sign are not welcome.

[nightroman]

Database paths/names with "=" sign are not welcome.
This is probably a feature but it bites. It's probably the design flaw.

LiteDatabase and ConnectionString constructors accept both database paths
and connection strings. This is "convenient" and usually works fine in test
environments with some usual database paths used as arguments.

Then an app goes to production where any valid paths are possible, including
paths with "=", a valid directory and file name character. These path are
problematic.

Please find attached 3 XUnit tests.

• UsingFilePathDirectlyFails shows how LiteDatabase fails with a valid file path.
• UsingFilePathConnectionStringFails shows how LiteDatabase fails with ConnectionString with a valid file path.
• Workaround shows probably the only reliable way with ConnectionString default constructor.

This issue makes using file paths in LiteDatabase and ConnectionString not
needed in properly designed applications.

Possible solution? For example, instead ambiguous constructors add safe static
Create methods:

• LiteDatabase.CreateFromPath(string path)
• ConnectionString.CreateFromPath(string path)

_220630_kq-equal-sign-issue.zip

[rklfss]

Late to the party, but as I just implemented ConnectionString.ToString #2745 I stumbled upon this.

From my point of view, this is difficult to change.

Not smart, but if you replace test= with filename= in your example and leave the full path part, it would be
new ConnectionString("filename=1.LiteDB"). What would you expect?

You can however use the "long" form of the connection string. This works fine.
new ConnectionString("filename=\"filename=1.LiteDB\"").

So for your example it would be something like new ConnectionString($"filename=\"{dbPath.Replace("\"", "\\\"")}\").
Which only makes sense if you expect a connection string from a string. Otherwise if you really construct it the way as in your example I would consider the "Workaround" approach not as workaround but the way to go.