fix: add MSSQL dialect fallback for composite PK delete_many

MSSQL doesn't support tuple().in_() syntax for row value comparisons.
Use OR of AND conditions as fallback for MSSQL dialect.

Also fix mock repositories in unit tests to initialize _pk_columns
and _pk_attr_names attributes required by composite PK support.

Author: cofin

advanced_alchemy/repository/_async.py

@@ -1246,7 +1246,11 @@ async def delete_many(
 
                 for idx in range(0, len(normalized_ids), effective_chunk_size):
                     chunk = normalized_ids[idx : min(idx + effective_chunk_size, len(normalized_ids))]
-                    pk_filter = tuple_(*self._pk_columns).in_(chunk)
+                    pk_filter = (
+                        or_(*[self._build_pk_filter(pk_tuple) for pk_tuple in chunk])
+                        if self._dialect.name == "mssql"
+                        else tuple_(*self._pk_columns).in_(chunk)
+                    )
 
                     if self._dialect.delete_executemany_returning:
                         returning_delete_stmt = delete(self.model_type).where(pk_filter).returning(self.model_type)

advanced_alchemy/repository/_sync.py

@@ -1247,7 +1247,11 @@ def delete_many(
 
                 for idx in range(0, len(normalized_ids), effective_chunk_size):
                     chunk = normalized_ids[idx : min(idx + effective_chunk_size, len(normalized_ids))]
-                    pk_filter = tuple_(*self._pk_columns).in_(chunk)
+                    pk_filter = (
+                        or_(*[self._build_pk_filter(pk_tuple) for pk_tuple in chunk])
+                        if self._dialect.name == "mssql"
+                        else tuple_(*self._pk_columns).in_(chunk)
+                    )
 
                     if self._dialect.delete_executemany_returning:
                         returning_delete_stmt = delete(self.model_type).where(pk_filter).returning(self.model_type)

tests/unit/test_service_to_model_flow.py

@@ -14,6 +14,7 @@
 import pytest
 
 from advanced_alchemy.repository import SQLAlchemyAsyncRepository, SQLAlchemySyncRepository
+from advanced_alchemy.repository._util import get_primary_key_info
 from advanced_alchemy.service import SQLAlchemyAsyncRepositoryService, SQLAlchemySyncRepositoryService
 from advanced_alchemy.service.typing import ATTRS_INSTALLED, MSGSPEC_INSTALLED, PYDANTIC_INSTALLED, ModelDictT
 
@@ -33,6 +34,8 @@ def __init__(self) -> None:
         # Don't call super().__init__ to avoid needing session
         self.model_type = MockModel
         self.id_attribute = "id"
+        # Initialize PK info for composite PK support
+        self._pk_columns, self._pk_attr_names = get_primary_key_info(MockModel)
 
 
 class MockSyncRepository(SQLAlchemySyncRepository[MockModel]):
@@ -44,6 +47,8 @@ def __init__(self) -> None:
         # Don't call super().__init__ to avoid needing session
         self.model_type = MockModel
         self.id_attribute = "id"
+        # Initialize PK info for composite PK support
+        self._pk_columns, self._pk_attr_names = get_primary_key_info(MockModel)
 
 
 class TrackingService(SQLAlchemyAsyncRepositoryService[MockModel, MockRepository]):