Skip to content

Commit b65dc41

Browse files
fix(opentelemetry): update tests for otel sdk 1.40.0 compatibility (#4662)
* fix(opentelemetry): update tests for otel sdk 1.40.0 compatibility * chore(opentelemetry): unpin opentelemetry-sdk from project's dev dependencies
1 parent ab72cc5 commit b65dc41

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ dev = [
146146
"psutil>=5.9.8",
147147
"hypercorn>=0.16.0",
148148
"daphne>=4.0.0",
149-
"opentelemetry-sdk<1.40.0",
149+
"opentelemetry-sdk",
150150
"httpx-sse",
151151
"structlog",
152152
]

tests/unit/test_contrib/test_opentelemetry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def resource() -> Resource:
3131

3232
@pytest.fixture(scope="session")
3333
def reader() -> InMemoryMetricReader:
34-
aggregation_last_value = {Counter: ExplicitBucketHistogramAggregation()}
34+
aggregation_last_value = {Counter: ExplicitBucketHistogramAggregation(boundaries=[])}
3535
return InMemoryMetricReader(preferred_aggregation=aggregation_last_value) # type: ignore[arg-type]
3636

3737

@@ -104,7 +104,7 @@ def handler() -> dict:
104104
resource_metrics = metric_data.resource_metrics[0]
105105
assert resource_metrics.scope_metrics
106106

107-
scope_metrics = resource_metrics.scope_metrics[0]
107+
scope_metrics = next(sm for sm in resource_metrics.scope_metrics if sm.scope.name != "opentelemetry-sdk")
108108
assert scope_metrics.metrics
109109

110110
request_metric = scope_metrics.metrics[0]

uv.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)