Skip to content

Bug: ResponseDataExtractor merges per cookie attributes #3040

New issue
New issue
Open
#3045
Open
Bug: ResponseDataExtractor merges per cookie attributes#3040
#3045
Labels
Bug 🐛This is something that is not working as expected
@floxay

Description

@floxay
floxay
opened on Jan 28, 2024

Description

Currently ResponseDataExtractor merges all values of cookies into a single dictionary, however cookies in the Set-Cookie header can have different flags, paths, domains, etc. set which are currently lost.

URL to code causing the issue

litestar/litestar/data_extractors.py

Lines 407 to 410 in e5f2b64

if cookie_string := ";".join(
[x[1].decode("latin-1") for x in filter(lambda x: x[0].lower() == b"set-cookie", messages[0]["headers"])]
):
parsed_cookies = parse_cookie_string(cookie_string)
Test showing how per cookie attributes (all attributes apart from key and value) are combined right now:

litestar/tests/unit/test_data_extractors.py

Line 110 in e5f2b64

assert extracted_data.get("cookies") == {"Path": "/", "SameSite": "lax", "auth": "", "regular": ""}

MCVE

No response

Steps to reproduce

No response

Screenshots

No response

Logs

No response

Litestar Version

v2.5.1

Platform

  • Linux
  • Mac
  • Windows
  • Other (Please specify in the description above)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug 🐛This is something that is not working as expected

    Type

    No type

    Projects

    Overview

    Status

    Working on it

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions