fix(builder): render materialized view data clauses

Author: cofin

sqlspec/builder/_ddl.py

@@ -1173,11 +1173,7 @@ def _create_base_expression(self) -> exp.Expr:
         for k, v in self._storage_parameters.items():
             props.append(exp.Property(this=exp.to_identifier(k), value=exp.convert(str(v))))
         if self._with_data is not None:
-            props.append(
-                exp.Property(
-                    this=exp.to_identifier("WITH_DATA" if self._with_data else "NO_DATA"), value=exp.Var(this="")
-                )
-            )
+            props.append(exp.WithDataProperty(no=not self._with_data))
         props.extend(exp.Property(this=exp.to_identifier("HINT"), value=exp.convert(hint)) for hint in self._hints)
         properties_node = _wrap_properties(props)
 

tests/unit/builder/test_expression_arg_contracts.py

@@ -107,3 +107,13 @@ def test_builder_expressions_satisfy_required_sqlglot_arguments() -> None:
     assert [(type(expression).__name__, expression.error_messages()) for expression in expressions] == [
         (type(expression).__name__, []) for expression in expressions
     ]
+
+
+def test_materialized_view_with_data_renders_postgres_clause() -> None:
+    expression = sql.create_materialized_view("mv").as_select("SELECT 1").with_data()._create_base_expression()
+    assert expression.sql(dialect="postgres") == "CREATE MATERIALIZED_VIEW mv AS SELECT 1 WITH DATA"
+
+
+def test_materialized_view_no_data_renders_postgres_clause() -> None:
+    expression = sql.create_materialized_view("mv").as_select("SELECT 1").no_data()._create_base_expression()
+    assert expression.sql(dialect="postgres") == "CREATE MATERIALIZED_VIEW mv AS SELECT 1 WITH NO DATA"