fix: accomodate for pending pods with no IP address in network fault (#684)

smitthakkar96 · ispeakc0de · web-flow · commit 96f6571e7777 · 2024-03-01T15:06:07.000+05:30
Signed-off-by: smit thakkar &lt;smit.thakkar@deliveryhero.com&gt;
Co-authored-by: Shubham Chaudhary &lt;shubham.chaudhary@harness.io&gt;
diff --git a/chaoslib/litmus/network-chaos/lib/network-chaos.go b/chaoslib/litmus/network-chaos/lib/network-chaos.go
@@ -358,6 +358,9 @@ func getPodIPFromService(host string, clients clients.ClientSets) ([]string, err
 		return ips, cerrors.Error{ErrorCode: cerrors.ErrorTypeGeneric, Target: fmt.Sprintf("{svcName: %s,podLabel: %s, namespace: %s}", svcNs, svcSelector, svcNs), Reason: fmt.Sprintf("failed to derive pods from service: %s", err.Error())}
 	}
 	for _, p := range pods.Items {
+		if p.Status.PodIP == "" {
+			continue
+		}
 		ips = append(ips, p.Status.PodIP)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -358,6 +358,9 @@ func getPodIPFromService(host string, clients clients.ClientSets) ([]string, err`
`358`	`358`	`return ips, cerrors.Error{ErrorCode: cerrors.ErrorTypeGeneric, Target: fmt.Sprintf("{svcName: %s,podLabel: %s, namespace: %s}", svcNs, svcSelector, svcNs), Reason: fmt.Sprintf("failed to derive pods from service: %s", err.Error())}`
`359`	`359`	`}`
`360`	`360`	`for _, p := range pods.Items {`
	`361`	`+ if p.Status.PodIP == "" {`
	`362`	`+ continue`
	`363`	`+ }`
`361`	`364`	`ips = append(ips, p.Status.PodIP)`
`362`	`365`	`}`
`363`	`366`