MSVC compiler: C4146: unary minus operator applied to unsigned type, result still unsigned

[bitzer-tjo]

Hi

That change from '(~a + 1)' to '-a' makes the MSVC compile fail if SDL is enabled.

We are using SDL option for many other reason.

Why is it changed to '-a' ?

Link: https://c.godbolt.org/z/7aMdf3s8a

Thomas

[geky]

Hi @bitzer-tjo,

Looking at git blame, I don't think that code has ever existed in this repo. Is it possibly a downstream project adopting a new release without keeping lfs_util.h changes?

Feel free to create a PR with ~a + 1 if you think it's worthwhile. I'm not opposed, though it may be very low priority.