Skip to content

Commit 55295de

Browse files
authored
chore: fix Windows CI and tidy check names (#1099)
## Summary - Suppress the C++/WinRT experimental coroutine deprecation error for `permission_handler_windows_plugin`. - Keeps the example Windows build working on the `windows-2025-vs2026` GitHub Actions image. - Shorten Build workflow job names so checks render as `Build / Android`, `Build / Dart Analyze`, etc. ## Testing - `git diff --check` - Parsed `.github/workflows/build.yaml` with Ruby YAML.
1 parent 3488ba8 commit 55295de

2 files changed

Lines changed: 17 additions & 12 deletions

File tree

.github/workflows/build.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ on:
2424

2525
jobs:
2626
dart-format-check:
27-
name: Dart Format Check
27+
name: Dart Format
2828
runs-on: ubuntu-latest
2929

3030
steps:
@@ -35,7 +35,7 @@ jobs:
3535
run: dart format . --set-exit-if-changed
3636

3737
import-sorter-check:
38-
name: Import Sorter Check
38+
name: Import Sorter
3939
runs-on: ubuntu-latest
4040

4141
steps:
@@ -46,7 +46,7 @@ jobs:
4646
run: dart run import_sorter:main --no-comments --exit-if-changed
4747

4848
version-consistency-check:
49-
name: Version Consistency Check
49+
name: Version Consistency
5050
runs-on: ubuntu-latest
5151

5252
steps:
@@ -57,7 +57,7 @@ jobs:
5757
run: dart run scripts/check_version.dart
5858

5959
dart-analyze-check:
60-
name: Dart Analyze Check
60+
name: Dart Analyze
6161
runs-on: ubuntu-latest
6262

6363
steps:
@@ -68,7 +68,7 @@ jobs:
6868
run: flutter analyze
6969

7070
dart-test-check:
71-
name: Dart Test Check
71+
name: Dart Test
7272
runs-on: ubuntu-latest
7373

7474
steps:
@@ -79,7 +79,7 @@ jobs:
7979
run: flutter test
8080

8181
build-for-android:
82-
name: Build for Flutter Android
82+
name: Android
8383
runs-on: ubuntu-latest
8484

8585
steps:
@@ -93,7 +93,7 @@ jobs:
9393
run: flutter build apk
9494

9595
build-for-ios:
96-
name: Build for Flutter iOS
96+
name: iOS
9797
runs-on: macos-latest
9898

9999
steps:
@@ -112,7 +112,7 @@ jobs:
112112
run: flutter build ios --release --no-codesign
113113

114114
build-for-windows:
115-
name: Build for Flutter Windows
115+
name: Windows
116116
runs-on: windows-latest
117117

118118
steps:
@@ -124,7 +124,7 @@ jobs:
124124
run: flutter build windows --release
125125

126126
build-for-macos:
127-
name: Build for Flutter macOS
127+
name: macOS
128128
runs-on: macos-latest
129129

130130
steps:
@@ -136,7 +136,7 @@ jobs:
136136
run: flutter build macos --release
137137

138138
build-for-linux:
139-
name: Build for Flutter Linux
139+
name: Linux
140140
runs-on: ubuntu-latest
141141

142142
steps:
@@ -154,7 +154,7 @@ jobs:
154154
run: flutter build linux
155155

156156
build-for-web:
157-
name: Build for Flutter Web
157+
name: Web
158158
runs-on: ubuntu-latest
159159

160160
steps:
@@ -168,7 +168,7 @@ jobs:
168168
run: flutter build web
169169

170170
build-for-web-wasm:
171-
name: Build for Flutter Web WASM
171+
name: Web WASM
172172
runs-on: ubuntu-latest
173173

174174
steps:

example/windows/CMakeLists.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ add_subdirectory("runner")
5050
# them to the application.
5151
include(flutter/generated_plugins.cmake)
5252

53+
# VS 2026 treats C++/WinRT's experimental coroutine include as a hard error.
54+
if(TARGET permission_handler_windows_plugin)
55+
target_compile_definitions(permission_handler_windows_plugin PRIVATE
56+
_SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS)
57+
endif()
5358

5459
# === Installation ===
5560
# Support files are copied into place next to the executable, so that it can

0 commit comments

Comments
 (0)