Commit 903bff0
authored
Remove non-public buttonPressed: selector from broadcast picker activation (#1138)
## Summary
Apple's automated App Review flags the literal `buttonPressed:` selector
string in application binaries (ITMS-90338 / Guideline 2.5.1) and blocks
App Store submissions. Since the plugin compiles `ios/Classes/**` into
every app, any iOS app using `livekit_client` is exposed — even if it
never uses screen sharing or ReplayKit.
`BroadcastManager.showPicker(for:)` constructed and performed the
private selector to programmatically activate the system broadcast
picker (reached via `setScreenShare` → `broadcastRequestActivation`
method channel). It now activates the picker using only public API:
locate the picker's `UIButton` subview and fire it via `sendActions(for:
.touchUpInside)`. If the button is ever not found (e.g. a future OS
changes the view hierarchy), a warning is logged instead of silently
no-opping.
No API changes; runtime behavior is identical.
## Verification
- `rg buttonPressed ios/ macos/` returns no matches, so the selector
string no longer reaches downstream binaries
- `swiftc -typecheck` against the iOS simulator SDK passes for the
changed file and its dependencies1 parent fdcedaa commit 903bff0
2 files changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
47 | | - | |
48 | | - | |
49 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
50 | 53 | | |
51 | 54 | | |
0 commit comments