Fix panic when ICE Restart RPC fails (#420)

Author: biglittlebigben

pkg/service/process_manager.go

@@ -290,7 +290,7 @@ func (p *process) DeleteWHIPResource(ctx context.Context, req *rpc.DeleteWHIPRes
 }
 
 func (p *process) ICERestartWHIPResource(ctx context.Context, req *rpc.ICERestartWHIPResourceRequest) (*rpc.ICERestartWHIPResourceResponse, error) {
-	return &rpc.ICERestartWHIPResourceResponse{}, nil
+	return &rpc.ICERestartWHIPResourceResponse{}, psrpc.NewErrorf(psrpc.UnprocessableEntity, "Trickle-ICE and ICE restart not supported")
 }
 
 func (p *process) WHIPRTCConnectionNotify(ctx context.Context, req *rpc.WHIPRTCConnectionNotifyRequest) (*google_protobuf2.Empty, error) {

pkg/whip/server.go

@@ -220,9 +220,9 @@ func (s *WHIPServer) Start(
 			RawTrickleIceSdpfrag: string(body),
 			IfMatch:              r.Header.Get("If-Match"),
 		}, psrpc.WithRequestTimeout(5*time.Second))
-		if err == psrpc.ErrNoResponse {
+		if err != nil {
 			s.handleError(err, w)
-			logger.Infow("WHIP ICE Restart failed no such session", "error", err, "streamKey", streamKey, "resourceID", resourceID)
+			logger.Infow("WHIP ICE restart failed", "error", err, "streamKey", streamKey, "resourceID", resourceID)
 			return
 		}