feat(sdp): pass direction to offer media and default empty to sendrecv

Author: OxSever

sdp/offer.go

@@ -119,7 +119,7 @@ func appendCryptoProfiles(attrs []sdp.Attribute, profiles []srtp.Profile) []sdp.
 }
 
 // OfferMediaWith creates a new SDP media description with a given codec set, public IP address and listening port.
-func OfferMediaWith(s *media.CodecSet, rtpListenerPort int, encrypted Encryption) (MediaDesc, *sdp.MediaDescription, error) {
+func OfferMediaWith(s *media.CodecSet, rtpListenerPort int, encrypted Encryption, dir sdp.Direction) (MediaDesc, *sdp.MediaDescription, error) {
 	// Static compiler check for frame duration hardcoded below.
 	var _ = [1]struct{}{}[20*time.Millisecond-rtp.DefFrameDur]
 
@@ -153,9 +153,12 @@ func OfferMediaWith(s *media.CodecSet, rtpListenerPort int, encrypted Encryption
 		attrs = appendCryptoProfiles(attrs, cryptoProfiles)
 	}
 
+	if dir == 0 {
+		dir = sdp.DirectionSendRecv
+	}
 	attrs = append(attrs, []sdp.Attribute{
 		{Key: "ptime", Value: "20"},
-		{Key: "sendrecv"},
+		{Key: dir.String()},
 	}...)
 
 	proto := "AVP"
@@ -182,7 +185,7 @@ func OfferMediaWith(s *media.CodecSet, rtpListenerPort int, encrypted Encryption
 //
 // Deprecated: use OfferMediaWith
 func OfferMedia(rtpListenerPort int, encrypted Encryption) (MediaDesc, *sdp.MediaDescription, error) {
-	return OfferMediaWith(media.GlobalCodecs(), rtpListenerPort, encrypted)
+	return OfferMediaWith(media.GlobalCodecs(), rtpListenerPort, encrypted, sdp.DirectionSendRecv)
 }
 
 // AnswerMedia creates a new SDP media description for an answer.
@@ -208,6 +211,9 @@ func AnswerMedia(rtpListenerPort int, audio *AudioConfig, crypt *srtp.Profile, d
 		proto = "SAVP"
 		attrs = appendCryptoProfiles(attrs, []srtp.Profile{*crypt})
 	}
+	if dir == 0 {
+		dir = sdp.DirectionSendRecv
+	}
 	attrs = append(attrs, []sdp.Attribute{
 		{Key: "ptime", Value: "20"},
 		{Key: dir.String()},
@@ -252,7 +258,7 @@ type Answer Description
 func NewOfferWith(s *media.CodecSet, publicIp netip.Addr, rtpListenerPort int, encrypted Encryption) (*Offer, error) {
 	sessId := rand.Uint64() // TODO: do we need to track these?
 
-	m, mediaDesc, err := OfferMediaWith(s, rtpListenerPort, encrypted)
+	m, mediaDesc, err := OfferMediaWith(s, rtpListenerPort, encrypted, sdp.DirectionSendRecv)
 	if err != nil {
 		return nil, err
 	}

sdp/offer_test.go

@@ -48,7 +48,7 @@ func TestSDPMediaOffer(t *testing.T) {
 	g := media.GlobalCodecs()
 
 	const port = 12345
-	_, offer, err := OfferMediaWith(g, port, EncryptionNone)
+	_, offer, err := OfferMediaWith(g, port, EncryptionNone, 0)
 	require.NoError(t, err)
 	require.Equal(t, &sdp.MediaDescription{
 		MediaName: sdp.MediaName{
@@ -68,7 +68,7 @@ func TestSDPMediaOffer(t *testing.T) {
 		},
 	}, offer)
 
-	_, offer, err = OfferMediaWith(g, port, EncryptionRequire)
+	_, offer, err = OfferMediaWith(g, port, EncryptionRequire, 0)
 	require.NoError(t, err)
 	i := slices.IndexFunc(offer.Attributes, func(a sdp.Attribute) bool {
 		return a.Key == "crypto"
@@ -99,7 +99,7 @@ func TestSDPMediaOffer(t *testing.T) {
 	noG722 := g.NewSet()
 	noG722.SetEnabled(g722.SDPNameAndRate, false)
 
-	_, offer, err = OfferMediaWith(noG722, port, EncryptionNone)
+	_, offer, err = OfferMediaWith(noG722, port, EncryptionNone, 0)
 	require.NoError(t, err)
 	require.Equal(t, &sdp.MediaDescription{
 		MediaName: sdp.MediaName{
@@ -326,7 +326,7 @@ func TestSDPMediaAnswer(t *testing.T) {
 			require.Equal(t, c.exp, got)
 		})
 	}
-	_, offer, err := OfferMediaWith(g, port, EncryptionNone)
+	_, offer, err := OfferMediaWith(g, port, EncryptionNone, 0)
 	require.NoError(t, err)
 	require.Equal(t, &sdp.MediaDescription{
 		MediaName: sdp.MediaName{