livepeer/starter: remove testTranscoder flag #2472
Conversation
…n O with no capabilities The -testTranscoder flag defaults to true which requires all hardware transcoders to call core.TestTranscoderCapabilities() to discover transcoding caps. Setting this flag to false is not a valid use case anymore so this change deprecates that option.
emranemran
force-pushed
the
user/emahbub/deprecate-testTranscoder-option
branch
from
d2ca380 to
3f98047
Compare
Codecov Report
@@ Coverage Diff @@
## master #2472 +/- ##
===================================================
+ Coverage 55.06159% 55.07886% +0.01726%
===================================================
Files 94 94
Lines 19727 19719 -8
===================================================
- Hits 10862 10861 -1
+ Misses 8263 8256 -7
Partials 602 602
Continue to review full report at Codecov.
|
|
Searching across all repos, it looks like we set it to false in some of our livepeer-in-a-box configs: https://github.com/search?q=org%3Alivepeer+testTranscoder&type=code @iameli would removing this break things? |
|
Tested on nvidia card with: |
|
Perhaps this flag in livepeer-in-a-box is alright for now since it's a fork. I'm guessing we'll have to setup automerges from |
|
I think we can merge this PR, since capability test runs only with hardware acceleration enabled. LGTM after rebasing. |
|
@emranemran could you please close up this ticket? |
What does this pull request do? Explain your changes. (required)
The -testTranscoder flag defaults to true which requires all hardware
transcoders to call core.TestTranscoderCapabilities() to discover
transcoding caps. Setting this flag to false is not a valid use case
anymore so this change deprecates that option.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Fix #2450
Checklist:
makeruns successfully[ ] All tests in./test.shpass