fix(envs): allow add env with one valid option, liv-7291 (#23)

* fix(envs): allow add env with one valid option

* Update package.json

Author: jinevo

__tests__/cmds/envs/add.spec.ts

@@ -3,57 +3,39 @@ import envs from '../../../src/cmds/envs'
 
 import { fromEnvsAddCmd } from '../../fixtures/configs'
 
-jest.mock('configstore');
+const makeOutput = config => {
+    const output = {
+        ...config
+    }
+
+    // @ts-ignore
+    output.apiToken = config['api-token']
+    delete output['api-token']
 
+    return output
+}
+
+jest.mock('configstore');
 const mockedConfigstore = jest.mocked(configStore, true)
 
-describe('Add command', () => {
-    const envName = 'boron'
+it('should call correctly the config store to set an entry', () => {
     const set = mockedConfigstore.mock.instances[0].set as jest.Mock
     envs({
-        _: ['add', envName],
+        _: ['add', 'env1'],
         ...fromEnvsAddCmd
     })
+    expect(set).toHaveBeenCalledTimes(1)
 
-    it('should call correctly the config store to set an entry', () => {
-        expect(set).toHaveBeenCalled()
-
-        const [ key, config ] = set.mock.calls[0]
-
-        expect(key).toBe(`envs.${envName}`)
-
-        const output = {
-            ...fromEnvsAddCmd
-        }
+    expect(set.mock.calls[0][0]).toBe(`envs.env1`)
+    expect(set.mock.calls[0][1]).toStrictEqual(makeOutput(fromEnvsAddCmd))
 
-        // @ts-ignore
-        output.apiToken = fromEnvsAddCmd['api-token']
-        delete output['api-token']
-        expect(config).toStrictEqual(output)
-    });
-
-    it('should update correctly an entry in the config store ', () => {
-        const dataTopdate = {
-            ...fromEnvsAddCmd,
-            endpoint: 'https://endpoint.fake'
-        }
-        envs({
-            _: ['add', envName],
-            ...dataTopdate
-        })
-
-        const [ key, config ] = set.mock.calls[1]
-
-        expect(key).toBe(`envs.${envName}`)
-
-        const output = {
-            ...fromEnvsAddCmd,
-            ...dataTopdate
-        }
+    // With --api-token only
+    envs({
+        _: ['add', 'env2'],
+        'api-token': fromEnvsAddCmd['api-token']
+    })
 
-        // @ts-ignore
-        output.apiToken = fromEnvsAddCmd['api-token']
-        delete output['api-token']
-        expect(config).toStrictEqual(output)
-    });
-})
+    expect(set).toHaveBeenCalledTimes(2)
+    expect(set.mock.calls[1][0]).toBe(`envs.env2`)
+    expect(set.mock.calls[1][1]).toStrictEqual(makeOutput({ 'api-token': fromEnvsAddCmd['api-token'] }))
+});

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@livestorm/cli",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "CLI that allows you to build and deploy your Livestorm plugin",
   "main": "index.js",
   "bin": {

src/cmds/envs.js

@@ -12,26 +12,27 @@ const ENV_CONFIG_FIELDS = [
 function add(envName, data) {
   if (!envName) {
     return console.log('\x1b[31m', 'The environment name is missing.')
+
   }
 
-  const fileredData = ENV_CONFIG_FIELDS.reduce((env, key) => {
+  const output = ENV_CONFIG_FIELDS.reduce((env, key) => {
     if (key in data) {
       env[key] = data[key]
     }
     return env
   }, {})
 
   if (data['api-token']) {
-    fileredData.apiToken = data['api-token']
+    output.apiToken = data['api-token']
   }
 
-  const dataIsValid = Object.keys(data).some(key => ENV_CONFIG_FIELDS.includes(key))
+  const outputIsValid = Object.keys(output).some(key => ENV_CONFIG_FIELDS.includes(key))
 
-  if (!dataIsValid) {
+  if (!outputIsValid) {
     return console.log('\x1b[31m', 'The configuration should contain at least one property.')
   }
 
-  configStore.set(`envs.${envName}`, fileredData)
+  configStore.set(`envs.${envName}`, output)
 
   if (configStore.has(`envs.${envName}`)) {
     console.log('\x1b[32m', `The configuration for the environment ${envName} has been added.`)