Bots should not attack charmed party / raid members

[mw108]

I've made a modification to mod-playerbots/src/strategy/actions/AttackAction.cpp in the function bool AttackAction::Attack with the goal that bots don't attack members of their own party or raid when the target is charmed or possessed. But this doesn't seem to work. I'm doing BWL and when fighting Nefarian bots keep killing raid members that are mindcontrolled by Nefarian. Any ideas what I'm doing wrong?

    if ((bot->IsInSameGroupWith((Player*)target) || bot->IsInSameRaidWith((Player*)target)) && (target->IsCharmed() || target->isPossessed() || target->IsPlayer()))
    {
        msg << " is in my group or raid and is charmed or possed or player";
        if (verbose)
            botAI->TellError(msg.str());

        return false;
    }

Edit

Even with the modification of the condition to simply check whether the target is in the same party or raid the bots keep attacking mindcontrolled raid members.

if (bot->IsInSameGroupWith((Player*)target) || bot->IsInSameRaidWith((Player*)target))
{
        msg << " is in my group or raid and is charmed or possed";
        if (verbose)
            botAI->TellError(msg.str());

        return false;
    }

[PaoloBenigni]

Hi! Feel free to submit a PR to incorporate this!

[mw108]

The problem is that it isn't working as expected and I'm wondering why.

Also, I don't think this is a generally wanted "feature" because if I remember correctly there are raids where you would want to quickly kill a possessed raid member.

[PaoloBenigni]

Maybe it's boss specific

[mw108]

The modifications are in the function that controls the general attacking behavior of the bot. I think it should work regardless of the boss.

[kadeshar]

When fight requires not attacking charmed/possesed character you should remove pvp strategy "/p co -pvp" "/p nc -pvp".
Personally i thinking that no modifications are required.

[mw108]

Interessting. Thanks. I'll try that.

[Dreathean]

That's a smart way to handle that situation. Just gotta remember that for the few odd times you encounter it!