Skip to content

Commit 29026fa

Browse files
authored
chore: disable another flaky Node compat test (denoland#20846)
1 parent d868bae commit 29026fa

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

cli/tests/node_compat/test/internet/test-dns.js

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -214,24 +214,26 @@ TEST(async function test_resolveNs(done) {
214214
checkWrap(req);
215215
});
216216

217-
TEST(function test_resolveNs_failure(done) {
218-
dnsPromises.resolveNs(addresses.NOT_FOUND)
219-
.then(common.mustNotCall())
220-
.catch(common.mustCall((err) => {
221-
assert.strictEqual(err.code, 'ENOTFOUND');
222-
}));
217+
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
218+
// instead of `ENOTFOUND`.
219+
// TEST(function test_resolveNs_failure(done) {
220+
// dnsPromises.resolveNs(addresses.NOT_FOUND)
221+
// .then(common.mustNotCall())
222+
// .catch(common.mustCall((err) => {
223+
// assert.strictEqual(err.code, 'ENOTFOUND');
224+
// }));
223225

224-
const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) {
225-
assert.ok(err instanceof Error);
226-
assert.strictEqual(err.code, 'ENOTFOUND');
226+
// const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) {
227+
// assert.ok(err instanceof Error);
228+
// assert.strictEqual(err.code, 'ENOTFOUND');
227229

228-
assert.strictEqual(result, undefined);
230+
// assert.strictEqual(result, undefined);
229231

230-
done();
231-
});
232+
// done();
233+
// });
232234

233-
checkWrap(req);
234-
});
235+
// checkWrap(req);
236+
// });
235237

236238
TEST(async function test_resolveSrv(done) {
237239
function validateResult(result) {

0 commit comments

Comments
 (0)