[Fix] parse: optimize segment addition in splitKeyIntoSegments function

techouse · techouse · commit 98bc892943ae · 2026-02-17T21:34:43.000Z
diff --git a/lib/parse.js b/lib/parse.js
@@ -270,7 +270,7 @@ var splitKeyIntoSegments = function splitKeyIntoSegments(originalKey, options) {
 
         if (close < 0) {
             // Unterminated group: wrap the raw remainder once as a single literal segment
-            segments.push('[' + key.slice(open) + ']');
+            segments[segments.length] = '[' + key.slice(open) + ']';
             return segments;
         }
 
@@ -281,7 +281,7 @@ var splitKeyIntoSegments = function splitKeyIntoSegments(originalKey, options) {
             return;
         }
 
-        segments.push(seg);
+        segments[segments.length] = seg;
         collected += 1;
 
         // find the next '[' after this balanced group

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ var splitKeyIntoSegments = function splitKeyIntoSegments(originalKey, options) {`
`270`	`270`
`271`	`271`	`if (close < 0) {`
`272`	`272`	`// Unterminated group: wrap the raw remainder once as a single literal segment`
`273`		`- segments.push('[' + key.slice(open) + ']');`
	`273`	`+ segments[segments.length] = '[' + key.slice(open) + ']';`
`274`	`274`	`return segments;`
`275`	`275`	`}`
`276`	`276`
`@@ -281,7 +281,7 @@ var splitKeyIntoSegments = function splitKeyIntoSegments(originalKey, options) {`
`281`	`281`	`return;`
`282`	`282`	`}`
`283`	`283`
`284`		`- segments.push(seg);`
	`284`	`+ segments[segments.length] = seg;`
`285`	`285`	`collected += 1;`
`286`	`286`
`287`	`287`	`// find the next '[' after this balanced group`