refactoring: naming

Author: redone

Diff for: includes/cray.h

@@ -160,13 +160,13 @@ void						init(t_seer *pSeer);
 void						position_direction(t_seer *pSeer, t_camera *pCamera,
 								int xPixel);
 void						calculate_initial_distance(t_seer *pSeer, t_camera *pCamera);
-void						dda(t_seer *pSeer, t_camera *pCamera, int *side);
+void						dda_loop(t_seer *pSeer, t_camera *pCamera, int *side);
 void						vertline(t_seer *pSeer, t_camera *pCamera,
 								int side);
 unsigned int				get_image_color(mlx_image_t *image, t_point p);
 void						set_texture_params(t_seer *pSeer, int xPixel);
 void						set_env(t_seer *pSeer);
 void						draw_3d_scene(t_seer *pSeer);
-void						fill_texture_buffer(t_seer *pSeer, int x,
+void						fill_texture_buffer(t_seer *pSeer, int xPixel,
 								int drawStart, int drawEnd);
 #endif // !CRAY_H

Diff for: srcs/hooks.c

@@ -38,7 +38,7 @@ void	draw_hook(void *args)
 	{
 		position_direction(seer, &seer->camera, x);
 		calculate_initial_distance(seer, &seer->camera);
-		dda(seer, &seer->camera, &seer->texture.side);
+		dda_loop(seer, &seer->camera, &seer->texture.side);
 		vertline(seer, &seer->camera, seer->texture.side);
 		set_texture_params(seer, x);
 	}

Diff for: srcs/raycasting.c

@@ -13,6 +13,10 @@ void	position_direction(t_seer *pSeer, t_camera *pCamera, int xPixel)
 	pSeer->dda.scaling_factor.y = sqrt(1 + (pCamera->direction.x * pCamera->direction.x) / (pCamera->direction.y * pCamera->direction.y));
 }
 
+/*
+	adding 1.0 to the player position
+	is to avoid the case where the player is on the grid.
+*/
 void	calculate_initial_distance(t_seer *pSeer, t_camera *pCamera)
 {
 	if (pCamera->direction.x < 0)
@@ -41,7 +45,7 @@ void	calculate_initial_distance(t_seer *pSeer, t_camera *pCamera)
 	}
 }
 
-void	dda(t_seer *pSeer, t_camera *pCamera, int *side)
+void	dda_loop(t_seer *pSeer, t_camera *pCamera, int *side)
 {
 	while (true)
 	{
@@ -62,6 +66,13 @@ void	dda(t_seer *pSeer, t_camera *pCamera, int *side)
 	}
 }
 
+/*
+	* ( 1 - step_x ) / 2 = 1 : if step_x = -1 and 0 : if step_x = 1
+		why?	because if step_x = -1, then the player is on the right side of the wall,
+				1 is already added in the calculation of the initial distance.
+	* mapX - playerX + (1 - stepX) / 2 is the number of square the player has to crossed in the X axis.
+	pCamera.direction is the ray direction vector so we can get the perpendicular wall distance.
+*/
 void	vertline(t_seer *pSeer, t_camera *pCamera, int side)
 {
 	if (side == HORIZONTAL)
@@ -70,7 +81,7 @@ void	vertline(t_seer *pSeer, t_camera *pCamera, int side)
 		pCamera->wall_distance = fabs((pCamera->map_y - pSeer->player.position.y + (1 - pSeer->dda.step_y) / 2) / pCamera->direction.y);
 	if (pCamera->wall_distance == 0)
 		pCamera->wall_distance = 0.0001;
-	pSeer->vertline.height = SCREEN_HEIGHT / pCamera->wall_distance;
+	pSeer->vertline.height = fabs(SCREEN_HEIGHT / pCamera->wall_distance);
 	pSeer->vertline.start = -pSeer->vertline.height / 2 + SCREEN_HEIGHT / 2;
 	if (pSeer->vertline.start < 0)
 		pSeer->vertline.start = 0;

Diff for: srcs/textures.c

@@ -1,5 +1,6 @@
 #include "../includes/cray.h"
 
+// the floor is used to get the value between 0 and 1
 void	set_texture_params(t_seer *pSeer, int xPixel)
 {
 	double	wall_x;
@@ -16,7 +17,7 @@ void	set_texture_params(t_seer *pSeer, int xPixel)
 		pSeer->texture.tex_x = CUBE_SIZE - pSeer->texture.tex_x - 1;
 	if (pSeer->texture.side == VERTICAL && pSeer->camera.direction.y < 0)
 		pSeer->texture.tex_x = CUBE_SIZE - pSeer->texture.tex_x - 1;
-	pSeer->texture.step = 1.0 * CUBE_SIZE / pSeer->vertline.height;
+	pSeer->texture.step = CUBE_SIZE / (double)pSeer->vertline.height;
 	pSeer->texture.pos = (pSeer->vertline.start - SCREEN_HEIGHT / 2
 			+ pSeer->vertline.height / 2) * pSeer->texture.step;
 	fill_texture_buffer(pSeer, xPixel, pSeer->vertline.start,
@@ -66,7 +67,7 @@ void	draw_3d_scene(t_seer *pSeer)
 	}
 }
 
-void	fill_texture_buffer(t_seer *pSeer, int x, int drawStart, int drawEnd)
+void	fill_texture_buffer(t_seer *pSeer, int xPixel, int drawStart, int drawEnd)
 {
 	int		tex_y;
 	int		y;
@@ -79,16 +80,16 @@ void	fill_texture_buffer(t_seer *pSeer, int x, int drawStart, int drawEnd)
 		pSeer->texture.pos += pSeer->texture.step;
 		cord = (t_point){pSeer->texture.tex_x, tex_y};
 		if (pSeer->texture.side == HORIZONTAL && pSeer->camera.direction.x > 0)
-			pSeer->texture.buffer[y][x] = \
+			pSeer->texture.buffer[y][xPixel] = \
 				get_image_color(pSeer->map_info.south_image, cord);
 		else if (pSeer->texture.side == HORIZONTAL)
-			pSeer->texture.buffer[y][x] = \
+			pSeer->texture.buffer[y][xPixel] = \
 				get_image_color (pSeer->map_info.north_image, cord);
 		else if (pSeer->camera.direction.y > 0)
-			pSeer->texture.buffer[y][x] = \
+			pSeer->texture.buffer[y][xPixel] = \
 				get_image_color (pSeer->map_info.east_image, cord);
 		else
-			pSeer->texture.buffer[y][x] = \
+			pSeer->texture.buffer[y][xPixel] = \
 				get_image_color (pSeer->map_info.west_image, cord);
 	}
 }

Diff for: srcs/utils.c

@@ -5,7 +5,7 @@ unsigned int	get_image_color(mlx_image_t *image, t_point p)
 	unsigned int	color;
 	unsigned int	index;
 
-	index = (p.y % image->height * image->width + p.x % image->width)
+	index = ((p.y % image->height) * image->width + (p.x % image->width))
 		* sizeof(unsigned int);
 	color = image->pixels[index] << 24;
 	color |= image->pixels[index + 1] << 16;