Quiet Slack slash command responses

Author: lladawn

app/api/slack/commands/route.js

@@ -16,8 +16,6 @@ import {
   slackConnectUrl,
   slackHelpPayload,
   slackSavedDumpPayload,
-  slackSavingPayload,
-  slackRoomModalOpenedPayload,
   openSlackRoomModal,
 } from "../../../../src/server/slack";
 import { cleanString } from "../../../../src/server/validation";
@@ -42,7 +40,7 @@ export async function POST(request) {
           await postSlackResponse(responseUrl, ephemeralText(error.message || "couldn't open room setup."));
         }
       });
-      return ok(slackRoomModalOpenedPayload());
+      return ok({});
     }
 
     after(async () => {
@@ -57,7 +55,7 @@ export async function POST(request) {
       }
     });
 
-    return ok(roomName !== null ? ephemeralText("creating a mumbl room...") : slackSavingPayload());
+    return ok({});
   } catch (error) {
     return serverError(error);
   }
@@ -80,15 +78,15 @@ async function saveOrConnect({ teamId, slackUserId, content, sourceMeta }) {
   const existingConnection = await findSlackConnection({ teamId, slackUserId });
   if (existingConnection) {
     const dump = await saveSlackDump({ connection: existingConnection, content, sourceMeta });
-    return slackSavedDumpPayload({ url: dumpUrl(dump.id) });
+    return slackSavedDumpPayload({ url: dumpUrl(dump.id), compact: true });
   }
 
   const email = await getSlackUserEmail({ teamId, slackUserId });
   const mumblUserId = await findMumblUserByEmail(email);
   if (mumblUserId) {
     const connection = await connectSlackUser({ teamId, slackUserId, mumblUserId });
     const dump = await saveSlackDump({ connection, content, sourceMeta });
-    return slackSavedDumpPayload({ url: dumpUrl(dump.id) });
+    return slackSavedDumpPayload({ url: dumpUrl(dump.id), compact: true });
   }
 
   const pending = await createPendingSlackDump({ teamId, slackUserId, content, sourceMeta });

src/server/slack.js

@@ -559,16 +559,9 @@ export function ephemeralText(text) {
   };
 }
 
-export function slackSavingPayload() {
-  return blockResponse({
-    text: "saving to mumbl...",
-    blocks: [
-      section("*saving to mumbl...*\nkeeping it private while mumbl files it away."),
-    ],
-  });
-}
+export function slackSavedDumpPayload({ url, shortcut = false, compact = false }) {
+  if (compact) return ephemeralText("saved privately to mumbl.");
 
-export function slackSavedDumpPayload({ url, shortcut = false }) {
   return blockResponse({
     text: shortcut ? "saved to mumbl privately." : "saved. only you can see this.",
     blocks: [
@@ -608,10 +601,6 @@ export function slackRoomNeedsNamePayload() {
   });
 }
 
-export function slackRoomModalOpenedPayload() {
-  return ephemeralText("opening room setup...");
-}
-
 export function slackRoomCreatedPayload({ space, openUrl, roomUrl, teamReadsUrl }) {
   return blockResponse({
     text: `created a mumbl room for ${space.name}.`,