Skip to content

Commit e94f781

Browse files
Adjusted the expiry time for the cache values (#17)
- Set the default expire time to null (no expire). - Adjust expire of different components.
1 parent c5dc051 commit e94f781

8 files changed

Lines changed: 12 additions & 19 deletions

src/hooks/api/useGetHistoryApi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export default function useGetHistoryApi(): UseGetHistoryApiResponse {
4343
const response = await getHistory(options);
4444
if (response.data) {
4545
setError(null);
46-
setCache("history" + sessionId, response.data, 120);
46+
setCache("history" + sessionId, response.data);
4747
setLoading(false);
4848
setLastSessionId(sessionId);
4949
return response.data;

src/hooks/api/useGetKnowledgeApi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export default function useGetKnowledgeApi({
6464
setCacheNotFound(cacheNotFoundKey, true, null);
6565
throw new Error("Knowledge not found");
6666
} else {
67-
setCache(cacheKey, response.data, 120);
67+
setCache(cacheKey, response.data);
6868
}
6969
setKnowledge(response.data);
7070
})

src/hooks/api/useGetModelsApi.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ export default function useAvailableModels(): UseAvailableModelsResponse {
2828
getModels()
2929
.then((response) => {
3030
if (response.data) {
31-
setCache("models", response.data, 120);
31+
setCache("models", response.data);
3232
setModels(response.data);
3333
} else {
34-
setCache("models", [], 120);
34+
setCache("models", []);
3535
setModels([]);
3636
}
3737
})

src/services/CacheService.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default function CacheProvider<T>({
4040

4141
// ttl in seconds
4242
// ttl = null means cache forever, so no expiry
43-
function setCache(key: string, value: T, ttl: number | null = 10) {
43+
function setCache(key: string, value: T, ttl: number | null = null) {
4444
if (ttl === null) {
4545
map.set(key, {
4646
expiry: null,

src/services/GetKnowledgeListService.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default function GetKnowledgeListProvider({
4848
const response = await getAllKnowledge();
4949
setError(null);
5050
if (response.data) {
51-
setCache("allKnowledge", response.data, 120);
51+
setCache("allKnowledge", response.data);
5252
setAllKnowledge(response.data);
5353
}
5454
} catch (error) {
@@ -72,7 +72,7 @@ export default function GetKnowledgeListProvider({
7272
(k) => k.id !== knowledge.id,
7373
);
7474
setAllKnowledge(updatedKnowledge);
75-
setCache("allKnowledge", updatedKnowledge, 120);
75+
setCache("allKnowledge", updatedKnowledge);
7676
};
7777

7878
// add multiple knowledge to local state
@@ -92,7 +92,7 @@ export default function GetKnowledgeListProvider({
9292
}
9393
const updatedKnowledge = allKnowledgeRef.current.concat(knowledgeToAdd);
9494
setAllKnowledge(updatedKnowledge);
95-
setCache("allKnowledge", updatedKnowledge, 120);
95+
setCache("allKnowledge", updatedKnowledge);
9696
};
9797

9898
// update Knowledge in local state
@@ -107,7 +107,7 @@ export default function GetKnowledgeListProvider({
107107
}
108108
const updatedKnowledges = filteredKnowledges.concat(newKnowledgeArray);
109109
setAllKnowledge(updatedKnowledges);
110-
setCache("allKnowledge", updatedKnowledges, 120);
110+
setCache("allKnowledge", updatedKnowledges);
111111
};
112112

113113
const contextValue = useMemo(

src/services/GetSessionsService.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export default function GetSessionsProvider({
6565
setError(null);
6666
if (response.data) {
6767
setSessions(response.data);
68-
setCache("sessions", response.data, 120);
68+
setCache("sessions", response.data);
6969
} else {
7070
setSessions([]);
7171
}

src/tests/services/CacheService.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe("CacheProvider", () => {
6565

6666
act(() => {
6767
// Set cache with 10 seconds TTL (default)
68-
result.current.setCache("shortLived", "will expire");
68+
result.current.setCache("shortLived", "will expire", 10);
6969
});
7070

7171
expect(result.current.getCache("shortLived")).toBe("will expire");

src/tests/services/GetKnowledgeListProvider.test.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,7 @@ describe("GetKnowledgeListProvider", () => {
156156
// Wait for the API call to complete
157157
await waitFor(() => {
158158
expect(getAllKnowledge).toHaveBeenCalledTimes(1);
159-
expect(mockSetCache).toHaveBeenCalledWith(
160-
"allKnowledge",
161-
mockKnowledge,
162-
120,
163-
);
159+
expect(mockSetCache).toHaveBeenCalledWith("allKnowledge", mockKnowledge);
164160
expect(contextValue.allKnowledge).toEqual(mockKnowledge);
165161
});
166162
});
@@ -246,7 +242,6 @@ describe("GetKnowledgeListProvider", () => {
246242
expect(mockSetCache).toHaveBeenCalledWith(
247243
"allKnowledge",
248244
expectedKnowledge,
249-
120,
250245
);
251246
});
252247

@@ -317,7 +312,6 @@ describe("GetKnowledgeListProvider", () => {
317312
expect(mockSetCache).toHaveBeenCalledWith(
318313
"allKnowledge",
319314
expectedKnowledge,
320-
120,
321315
);
322316
});
323317

@@ -442,7 +436,6 @@ describe("GetKnowledgeListProvider", () => {
442436
expect(mockSetCache).toHaveBeenCalledWith(
443437
"allKnowledge",
444438
expectedKnowledge,
445-
120,
446439
);
447440
});
448441

0 commit comments

Comments
 (0)