Commit 7eb291a
fix: replace ClusterRoleBinding to view with namespace-scoped pods permission (#310)
The test-requester binary's getPodUIDs() lists pods in the test namespace
to sweep stale GPU allocations. This permission was previously supplied via
a ClusterRoleBinding to the built-in view ClusterRole, which is a
cluster-scoped object requiring cluster-admin privileges and preventing
concurrent test runs.
Replace it with an explicit get/list/watch rule on pods added to the
existing namespace-scoped testreq Role. Remove all creation and cleanup
of the testreq-view ClusterRoleBinding from every test script and the
OpenShift CI workflow.
Fixes #309 (sub-issue of #276).
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 0f70f3e commit 7eb291a
File tree
4 files changed
+27
-6
lines changed- .github/workflows
- inference_server/benchmark
- test/e2e
4 files changed
+27
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
588 | 588 | | |
589 | 589 | | |
590 | 590 | | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
591 | 594 | | |
592 | 595 | | |
593 | 596 | | |
| |||
596 | 599 | | |
597 | 600 | | |
598 | 601 | | |
599 | | - | |
600 | | - | |
601 | 602 | | |
602 | 603 | | |
603 | 604 | | |
| |||
923 | 924 | | |
924 | 925 | | |
925 | 926 | | |
926 | | - | |
927 | 927 | | |
928 | 928 | | |
929 | 929 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
62 | 70 | | |
63 | 71 | | |
64 | 72 | | |
65 | | - | |
66 | 73 | | |
67 | 74 | | |
68 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
111 | 119 | | |
112 | 120 | | |
113 | 121 | | |
114 | | - | |
115 | 122 | | |
116 | 123 | | |
117 | 124 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
107 | 115 | | |
108 | 116 | | |
109 | 117 | | |
110 | | - | |
111 | 118 | | |
112 | 119 | | |
113 | 120 | | |
| |||
0 commit comments