File tree Expand file tree Collapse file tree 2 files changed +18
-7
lines changed
Expand file tree Collapse file tree 2 files changed +18
-7
lines changed Original file line number Diff line number Diff line change @@ -908,11 +908,6 @@ jobs:
908908 kubectl delete namespace "$FMA_NAMESPACE" \
909909 --ignore-not-found --timeout=120s || true
910910
911- # Delete CRDs
912- # TODO: Implement safe CRD lifecycle management for tests (e.g., handle shared clusters,
913- # concurrent test runs, and version upgrades/downgrades) before enabling CRD deletion.
914- # kubectl delete -f config/crd/ --ignore-not-found || true
915-
916911 echo "Cleanup complete"
917912
918913 - name : Scale down controller on failure
Original file line number Diff line number Diff line change @@ -23,8 +23,6 @@ object.
2323- A ClusterRoleBinding that binds the node-reading ClusterRole to an
2424 FMA ServiceAccount.
2525
26- - A ClusterRoleBinding that binds ClusterRole ` view ` to an FMA ServiceAccount.
27-
2826- A Namespace that FMA is installed in.
2927
3028## Solution for the CustomResourceDefinition Objects
@@ -138,3 +136,21 @@ object.
138136 ValidatingAdmissionPolicy[Binding] objects.
139137
140138- The Helm chart does nothing about these policy objects.
139+
140+ ## Solution for reading Node objects
141+
142+ - The Helm chart can optionally create a ClusterRoleBinding for a
143+ ClusterRole with a given name.
144+
145+ - The Helm chart does nothing about creating the ClusterRole for
146+ reading Node objects.
147+
148+ - The admin of a shared cluster has several choices about what to
149+ maintain on behalf of users vs. authorize users to do.
150+
151+ - The shared OpenShift cluster that we use for CI and developer
152+ testing already authorizes every ServiceAccount to read Node
153+ objects. The GHA workflow for E2E testing in the shared OpenShift
154+ cluster: (a) does not create/update/delete a ClusterRole for reading
155+ Node objects and (b) tells the Helm chart to NOT include the
156+ ClusterRoleBinding.
You can’t perform that action at this time.
0 commit comments