Skip to content

Commit e2908b4

Browse files
committed
Unify launcher unit testing
Make the GHA workflow use the requirements file. Update the requirements file to versions that are more recent AND work on MacOS. Make all the instructions about running the tests consistent. Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
1 parent cf92c6d commit e2908b4

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

.github/workflows/python-code-quality.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
# install black isort flake
3535
pip install black==24.4.2 isort==5.13.2 flake8==7.0.0
3636
# install pytest and other dependencies
37-
pip install pytest==9.0.2 fastapi==0.116.1 pydantic==2.11.7 uvicorn==0.35.0 uvloop==0.21.0 httpx==0.28.1 nvidia-ml-py==13.590.48 kubernetes==31.0.0
37+
pip install pytest==9.0.2 -r inference_server/launcher/requirements-sans-vllm.txt
3838
3939
- name: Check for trailing whitespace
4040
run: |

inference_server/launcher/howto.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
1- HOW TO RUN THE UNIT TEST:
22

3-
Install all the necessary packages:
3+
Install all the necessary packages (feel free to use a later version of pytest if you prefer):
44
```bash
5-
pip install -r requirements.txt
5+
pip install pytest==9.0.2 -r requirements-sans-vllm.txt
66
```
77

88
Run the unit test doing:
99
```bash
10-
python -m pytest test_launcher.py -v
10+
python -m pytest tests/test_launcher.py -v
11+
python -m pytest tests/test_gputranslator.py -v
1112
```
1213

1314
2- RUN E2E TEST:
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
fastapi==0.135.1
2+
pydantic==2.12.5
3+
uvicorn==0.42.0
4+
uvloop==0.22.1
5+
httpx==0.28.1
6+
nvidia-ml-py==13.590.48
7+
kubernetes==31.0.0
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
fastapi
2-
pydantic
3-
uvicorn
4-
uvloop
5-
nvidia-ml-py
6-
kubernetes==31.0.0
1+
-r requirements-sans-vllm.txt
72
# WARNING: vllm must be built from source on a macOS Silicon
83
vllm; sys_platform != "darwin" or platform_machine != "arm64"

0 commit comments

Comments
 (0)