Calling BuildLauncherPodFromTemplate here is a lot of wasted work. I see that it is necessary because the only hash available takes the Node name into account. If BuildLauncherPodFromTemplate also returned an additional hash that does NOT take the Node name into account then, for purposes of this consistency checking, it would only be necessary to call BuildLauncherPodFromTemplate once per ResourceVersion of the LauncherConfig. This improvement could be made in a follow-on PR, but should be made.
Originally posted by @MikeSpreitzer in #374 (comment)
Calling BuildLauncherPodFromTemplate here is a lot of wasted work. I see that it is necessary because the only hash available takes the Node name into account. If BuildLauncherPodFromTemplate also returned an additional hash that does NOT take the Node name into account then, for purposes of this consistency checking, it would only be necessary to call BuildLauncherPodFromTemplate once per ResourceVersion of the LauncherConfig. This improvement could be made in a follow-on PR, but should be made.
Originally posted by @MikeSpreitzer in #374 (comment)