update(GHA): bump action versions and simplify lint (#197)

* update(GHA): bump action versions and simplify lint

- only run if changes found on charts
- uplift action version to use new one
- remove download chart from GIE and GW
- move lychee to use action and config move to .github

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* fix: markdown lint

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

Author: zdtsw

.github/lychee.toml

@@ -0,0 +1,11 @@
+# Lychee link checker configuration
+# https://lychee.cli.rs/
+
+# Accept non-200 status codes (429: rate limits)
+accept = ["200", "429"]
+
+# Timeout per request (seconds)
+timeout = 20
+
+# Retry failed requests
+max_retries = 3

.github/workflows/lint-charts.yaml

@@ -3,11 +3,30 @@ name: Lint and Test Charts
 on: pull_request
 
 jobs:
+  detect-changes:
+    runs-on: ubuntu-latest
+    outputs:
+      changed: ${{ steps.check.outputs.changed }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
+      - name: Check for chart changes
+        id: check
+        run: |
+          if git diff --name-only origin/${{ github.event.repository.default_branch }}...HEAD | grep -q '^charts/'; then
+            echo "changed=true" >> "$GITHUB_OUTPUT"
+          fi
+
   lint-test:
+    needs: detect-changes
+    if: needs.detect-changes.outputs.changed == 'true'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
 
@@ -16,30 +35,16 @@ jobs:
         with:
           version: v3.17.0
 
-      - uses: actions/setup-python@v5.3.0
-        with:
-          python-version: '3.x'
-          check-latest: true
-
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@v2.7.0
-
-      - name: Run chart-testing (list-changed)
-        id: list-changed
-        run: |
-          changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
-          if [[ -n "$changed" ]]; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-          fi
+        uses: helm/chart-testing-action@v2.8.0
 
       - name: Add Helm dependency repos
         run: |
           for dir in $(ls -d charts/*/); do
             helm dependency list  --max-col-width 120 $dir 2> /dev/null | tail +2 | head -n -1 | awk '{ print "helm repo add " $1 " " $3 }' | while read cmd; do $cmd; done
           done
 
-      - name: Run make lint for chart-testing
-        if: steps.list-changed.outputs.changed == 'true'
+      - name: Run make lint
         env:
           TARGET_BRANCH: ${{ github.event.repository.default_branch }}
         run: make lint
@@ -48,19 +53,7 @@ jobs:
         run: make verify
 
       - name: Create kind cluster
-        if: steps.list-changed.outputs.changed == 'true'
         uses: helm/kind-action@v1.12.0
 
-      - name: Install CRDs
-        if: steps.list-changed.outputs.changed == 'true'
-        run: |
-          # Install Kubernetes Gateway API CRDs
-          kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.3.0/standard-install.yaml
-
-          # Install Kubernetes Gateway API Inference Extension CRDs
-          VERSION=v0.3.0
-          kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/$VERSION/manifests.yaml
-
       - name: Run chart-testing (install)
-        if: steps.list-changed.outputs.changed == 'true'
         run: ct install --target-branch ${{ github.event.repository.default_branch }} --helm-extra-set-args "--set=accelerator.type=cpu"

.github/workflows/md-link-check.yml

@@ -14,13 +14,10 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
 
-      - name: Install lychee v0.18.1
-        run: |
-          curl -Ls https://github.com/lycheeverse/lychee/releases/download/lychee-v0.20.1/lychee-x86_64-unknown-linux-gnu.tar.gz | tar xz
-          sudo mv lychee /usr/local/bin
-
-      - name: Run lychee on Markdown files with config
-        run: |
-          find . -name "*.md" -print0 | xargs -0 lychee --config .lychee.toml --verbose --no-progress
+      - name: Run markdown link checker
+        uses: lycheeverse/lychee-action@v2.7.0
+        with:
+          args: --verbose --no-progress --include-fragments --format markdown --config .github/lychee.toml '**/*.md'
+          fail: true

.github/workflows/pre-commit.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
 

.github/workflows/re-run-action.yml

@@ -8,7 +8,7 @@ jobs:
   rerun_pr_tests:
     name: rerun_pr_tests
     if: ${{ github.event.issue.pull_request }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
     - uses: estroz/rerun-actions@main
       with:

.lychee.toml

@@ -23,7 +23,7 @@ We welcome contributions to the llm-d-modelservice chart! If you have a bug fix,
 
 Before submitting a pull request, please make sure you have the following tools installed:
 
-- [Helm](http://helm.sh/)
+- [Helm](https://helm.sh/)
 - [Chart Testing](https://github.com/helm/chart-testing)
 - [pre-commit](https://pre-commit.com/)
 <!-- TODO: Once supported, also install:
@@ -80,7 +80,7 @@ make pre-commit-run
 For every Pull Request submitted, ensure the following steps have been done:
 
 1. [Sign your commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
-2. [Sign-off your commits](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt-code--signoffcode)
+2. [Sign-off your commits](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff)
 3. Ensure that the `make lint`, `make verify` command runs successfully to validate your changes
 4. Update the version number in the [`charts/llm-d-modelservice/Chart.yaml`](charts/llm-d-modelservice/Chart.yaml) file using
    [semantic versioning](https://semver.org/). Follow the `X.Y.Z` format so the nature of the changes is reflected in the

CONTRIBUTING.md

@@ -44,7 +44,7 @@ Note that the field `llm-d.ai/role` will be addition in addition to the labels s
 
 ### HTTPRoute
 
-In addition to deploying the GAIE chart, an `HTTPRoute` is typically required to connect the `Gateway` to the `InferencePool`. Creating an HTTPRoute is not part of either chart. Some examples are provided [here](https://github.com/llm-d-incubation/llm-d-modelservice/blob/main/examples/README.md#httproute).
+In addition to deploying the GAIE chart, an `HTTPRoute` is typically required to connect the `Gateway` to the `InferencePool`. Creating an HTTPRoute is not part of either chart. Some examples are provided [here](examples/README.md#httproute-examples).
 
 ## Examples
 

README.md

@@ -14,11 +14,11 @@ helm repo update
 |---------|-------------|----------------------|
 | [`values-cpu.yaml`](#1-cpu-only) | CPU-only inference example | Single node, no GPU required |
 | [`values-pd.yaml`](#2-pd-disaggregation) | Prefill/decode disaggregation example | Multi-GPU, demonstrates P/D splitting |
-| [`values-xpu.yaml`](#5-intel-xpu-examples) | Intel XPU single-node example | Intel Data Center GPU Max |
-| [`pvc/`](#4-loading-a-model-from-a-pvc) | Persistent volume examples | Shows different storage options |
+| [`values-xpu.yaml`](#4-intel-xpu-examples) | Intel XPU single-node example | Intel Data Center GPU Max |
+| [`pvc/`](#3-loading-a-model-from-a-pvc) | Persistent volume examples | Shows different storage options |
 | [`dra/`](#6-dynamic-resource-allocation) | Dynamic Resource Allocation (DRA) examples | Shows different DRA use cases |
 
-All the examples assume a `Gateway` and GAIE configuration have been deployed.  See the [llm-d guides](https://github.com/llm-d/llm-d/tree/main/guides) for examples.  Further, an `HTTPRoute` must be deployed. Some examples of `HTTPRoute` is provided [below](https://github.com/llm-d-incubation/llm-d-modelservice/blob/main/examples/README.md#httproute).
+All the examples assume a `Gateway` and GAIE configuration have been deployed.  See the [llm-d guides](https://github.com/llm-d/llm-d/tree/main/guides) for examples.  Further, an `HTTPRoute` must be deployed. Some examples of `HTTPRoute` is provided [below](#httproute-examples).
 
 ## Usage Examples