Skip to content

Commit 91a950f

Browse files
committed
ci: add link checker
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
1 parent 8aff49f commit 91a950f

File tree

3 files changed

+41
-2
lines changed

3 files changed

+41
-2
lines changed
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
name: Markdown Link Checker
2+
3+
on:
4+
push:
5+
branches: [ main ]
6+
pull_request:
7+
branches: [ main ]
8+
workflow_dispatch:
9+
10+
jobs:
11+
lychee:
12+
name: Check Markdown Links
13+
runs-on: ubuntu-latest
14+
15+
steps:
16+
- name: Checkout code
17+
uses: actions/checkout@v5
18+
19+
- name: Install lychee v0.18.1
20+
run: |
21+
curl -Ls https://github.com/lycheeverse/lychee/releases/download/lychee-v0.20.1/lychee-x86_64-unknown-linux-gnu.tar.gz | tar xz
22+
sudo mv lychee /usr/local/bin
23+
24+
- name: Run lychee on Markdown files with config
25+
run: |
26+
find . -name "*.md" -print0 | xargs -0 lychee --config .lychee.toml --verbose --no-progress

.lychee.toml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Ignore transient failures on gnu.org (it sometimes refuses connections)
2+
exclude = [
3+
"^https://www.gnu.org/software/make/?$"
4+
]
5+
6+
# Timeout in seconds
7+
timeout = 20
8+
9+
# Retry failed links (helpful for flaky sites)
10+
retry_count = 3
11+
12+
# Accept non-200 status codes (429: rate limits)
13+
accept = [200, 429]

examples/pvc/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Examine [output-pvc.yaml](../output-pvc.yaml) to view the Kubernetes resources t
8383

8484
Note that the path after the `<pvc-name>` is the path on the PVC which the downloaded files can be found. If you don't know the path, create a debug pod (see an example manifest [here](./pvc-debugger.yaml)) and exec (`k exec -it pvc-debugger -- bin/bash`) into it to find out. The path should not contain the mountPath of that debug pod. For example, if inside the pod, the path is which model files can be found is `/mnt/huggingface/cache/models/`, then use just `huggingface/cache/models/` as the `<path/to/model>` because `/mnt` is specific to the mountPath of that debug pod.
8585

86-
Make sure that for the container of your interst in `prefill.containers` or `decode.containers`, there's a field called `mountModelVolume: true` ([see example](../values-pvc.yaml#L90)) for the volume mounts to be created correctly.
86+
Make sure that for the container of your interst in `prefill.containers` or `decode.containers`, there's a field called `mountModelVolume: true` ([see example](../values-pd.yaml#L87)) for the volume mounts to be created correctly.
8787

8888
### Behavior
8989
- A read-only PVC volume with the name `model-storage` is created for the deployment
@@ -118,7 +118,7 @@ helm install pvc-hf-example llm-d-modelservice/llm-d-modelservice \
118118
--set modelArtifacts.uri="pvc+hf://pvc-name/path/to/hf_hub_cache/facebook/opt-125m"
119119
```
120120

121-
Make sure that for the container of your interst in `prefill.containers` or `decode.containers`, there's a field called `mountModelVolume: true` ([see example](../values-pvc.yaml#L90)) for the volume mounts to be created correctly.
121+
Make sure that for the container of your interst in `prefill.containers` or `decode.containers`, there's a field called `mountModelVolume: true` ([see example](../values-pd.yaml#L87)) for the volume mounts to be created correctly.
122122

123123
### Behavior
124124
- A read-only PVC volume with the name `model-storage` is created for the deployment

0 commit comments

Comments
 (0)