refactor: use inline YAML from deploy response in UI

Remove second GET /deployments/{id}/yaml round-trip from both
api_client.deploy_and_generate_yaml() and the deployment component.
YAML contents are now read directly from the deploy response. Zip
download entries use proper filenames ({deployment_id}-{type}.yaml).

Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: Amit Oren <amoren@redhat.com>

Author: amito

ui/api_client.py

@@ -247,9 +247,9 @@ def extract_business_context(user_input: str) -> dict | None:
 
 
 def deploy_and_generate_yaml(recommendation: dict) -> dict | None:
-    """Deploy a recommendation and fetch generated YAML files.
+    """Deploy a recommendation and return generated YAML contents.
 
-    Returns dict with deployment_id, files, and success status, or None on error.
+    Returns dict with deployment_id, files (YAML contents), and success status, or None on error.
     """
     try:
         response = requests.post(
@@ -260,17 +260,10 @@ def deploy_and_generate_yaml(recommendation: dict) -> dict | None:
         response.raise_for_status()
         result = response.json()
         if result.get("success"):
-            deployment_id = result.get("deployment_id")
-            yaml_response = requests.get(
-                f"{API_BASE_URL}/api/v1/deployments/{deployment_id}/yaml",
-                timeout=DEFAULT_TIMEOUT,
-            )
-            yaml_response.raise_for_status()
-            yaml_data = yaml_response.json()
             return {
                 "success": True,
-                "deployment_id": deployment_id,
-                "files": yaml_data.get("files", {}),
+                "deployment_id": result.get("deployment_id"),
+                "files": result.get("files", {}),
             }
         else:
             return {"success": False, "message": result.get("message", "Unknown error")}

ui/components/deployment.py

@@ -83,17 +83,8 @@ def render_deployment_tab():
                     result = response.json()
 
                     if result.get("success"):
-                        deployment_id = result.get("deployment_id")
-                        st.session_state.deployment_id = deployment_id
-
-                        yaml_response = requests.get(
-                            f"{API_BASE_URL}/api/v1/deployments/{deployment_id}/yaml",
-                            timeout=10,
-                        )
-                        yaml_response.raise_for_status()
-                        yaml_data = yaml_response.json()
-
-                        st.session_state.deployment_yaml_files = yaml_data.get("files", {})
+                        st.session_state.deployment_id = result.get("deployment_id")
+                        st.session_state.deployment_yaml_files = result.get("files", {})
                         st.session_state.deployment_yaml_generated = True
                         st.rerun()
                     else:
@@ -117,7 +108,8 @@ def render_deployment_tab():
         if yaml_files:
             zip_buffer = io.BytesIO()
             with zipfile.ZipFile(zip_buffer, "w", zipfile.ZIP_DEFLATED) as zf:
-                for filename, content in yaml_files.items():
+                for config_type, content in yaml_files.items():
+                    filename = f"{deployment_id}-{config_type}.yaml"
                     zf.writestr(filename, content)
             zip_buffer.seek(0)