Skip to content

Commit 05d623a

Browse files
shmuelkvMaroon
authored andcommitted
Made variable assignment more consistent
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
1 parent 0e5f91e commit 05d623a

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

scripts/kind-dev-env.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,16 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
2626
: "${VLLM_SIMULATOR_IMAGE:=llm-d-inference-sim}"
2727

2828
# Set a default VLLM_SIMULATOR_TAG if not provided
29-
export VLLM_SIMULATOR_TAG="${VLLM_SIMULATOR_TAG:=0.0.6}"
29+
export VLLM_SIMULATOR_TAG="${VLLM_SIMULATOR_TAG:-0.0.6}"
3030

3131
# Set a default EPP_IMAGE if not provided
3232
: "${EPP_IMAGE:=llm-d-inference-scheduler}"
3333

3434
# Set a default EPP_TAG if not provided
35-
export EPP_TAG="${EPP_TAG:=0.0.4}"
35+
export EPP_TAG="${EPP_TAG:-0.0.4}"
3636

3737
# Set the default routing side car image tag
38-
export ROUTING_SIDECAR_TAG="${ROUTING_SIDECAR_TAG:=0.0.6}"
38+
export ROUTING_SIDECAR_TAG="${ROUTING_SIDECAR_TAG:-0.0.6}"
3939

4040
# Set the inference pool name for the deployment
4141
export POOL_NAME="${POOL_NAME:-vllm-llama3-8b-instruct}"
@@ -44,17 +44,17 @@ export POOL_NAME="${POOL_NAME:-vllm-llama3-8b-instruct}"
4444
export MODEL_NAME="${MODEL_NAME:-meta-llama/Llama-3.1-8B-Instruct}"
4545

4646
# vLLM replica count (without PD)
47-
export VLLM_REPLICA_COUNT="${VLLM_REPLICA_COUNT:=1}"
47+
export VLLM_REPLICA_COUNT="${VLLM_REPLICA_COUNT:-1}"
4848

4949
# By default we are not setting up for PD
50-
export PD_ENABLED="\"${PD_ENABLED:=false}\""
50+
export PD_ENABLED="\"${PD_ENABLED:-false}\""
5151

5252
# By default the PD threshhold is ten tokens
53-
export PD_PROMPT_LEN_THRESHOLD="\"${PD_PROMPT_LEN_THRESHOLD:=10}\""
53+
export PD_PROMPT_LEN_THRESHOLD="\"${PD_PROMPT_LEN_THRESHOLD:-10}\""
5454

5555
# Replica counts for P and D
56-
export VLLM_REPLICA_COUNT_P="${VLLM_REPLICA_COUNT_P:=1}"
57-
export VLLM_REPLICA_COUNT_D="${VLLM_REPLICA_COUNT_D:=2}"
56+
export VLLM_REPLICA_COUNT_P="${VLLM_REPLICA_COUNT_P:-1}"
57+
export VLLM_REPLICA_COUNT_D="${VLLM_REPLICA_COUNT_D:-2}"
5858

5959
# ------------------------------------------------------------------------------
6060
# Setup & Requirement Checks

0 commit comments

Comments
 (0)