Skip to content

Commit 0aa2587

Browse files
committed
follow up comments -2
Signed-off-by: Jooho Lee <jlee@redhat.com>
1 parent cb52d37 commit 0aa2587

File tree

4 files changed

+4
-40
lines changed

4 files changed

+4
-40
lines changed

.github/workflows/check-typos.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ jobs:
1313
uses: actions/checkout@v4
1414

1515
- name: Check typos
16-
uses: crate-ci/typos@v1.34.0
16+
uses: crate-ci/typos@v1.34.0
17+

.typos.toml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,6 @@ k8s = "k8s"
33
KServe = "KServe"
44
vLLM = "vLLM"
55
IST = "IST"
6-
parm = "parm"
7-
Ded = "Ded"
86

97
[files]
108
extend-exclude = ["*.png", "*.jpg", "deploy/"]
11-
12-
13-
[default.extend-replacements]
14-
teh = "the"
15-
funtion = "function"
16-
macthing = "matching"
17-
overriden = "overridden"
18-
instllation = "installation"
19-
componet = "component"
20-
avaialble = "available"
21-
availble = "available"
22-
desireable = "desirable"
23-
walkthough = "walkthrough"
24-
statments = "statements"
25-
consturctor = "constructor"
26-
Schedulling = "Scheduling"

Makefile

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -209,25 +209,12 @@ check-typos: $(TYPOS) ## Check for spelling errors using typos (exits with error
209209
echo "✅ No spelling errors found!"; \
210210
echo "🎉 Spelling check completed successfully!"; \
211211
else \
212-
echo "❌ Spelling errors found! \
212+
echo "❌ Spelling errors found!"; \
213213
echo "🔧 You can try 'make fix-typos' to automatically fix the spelling errors and run 'make check-typos' again"; \
214214
echo "$$TYPOS_OUTPUT"; \
215215
exit 1; \
216216
fi
217217

218-
fix-typos: $(TYPOS) ## Automatically fix spelling errors using typos
219-
@echo "🔍 Automatically fixing spelling errors with typos..."
220-
@TYPOS_OUTPUT=$$($(TYPOS) --write-changes --format brief 2>&1); \
221-
if [ $$? -eq 0 ]; then \
222-
echo "✅ No spelling errors found!"; \
223-
echo "🎉 Spelling check completed successfully!"; \
224-
else \
225-
echo "❌ Spelling errors found! You need to fix the spelling errors manually"; \
226-
echo "🔧 Please fix the spelling errors and run 'make check-typos' again"; \
227-
echo "$$TYPOS_OUTPUT"; \
228-
exit 1; \
229-
fi
230-
231218
##@ Tools
232219

233220
.PHONY: check-tools

Makefile.tools.mk

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
LOCALBIN ?= $(shell pwd)/bin
22
$(LOCALBIN):
3-
mkdir -p $(LOCALBIN)
4-
PYTHON_VENV = $(LOCALBIN)/.venv
5-
PYTHON_BIN = $(PYTHON_VENV)/bin
3+
[ -d $@ ] || mkdir -p $@
64

75
## Tool binary names.
86
TYPOS = $(LOCALBIN)/typos
@@ -16,7 +14,3 @@ $(TYPOS): | $(LOCALBIN)
1614
@echo "Downloading typos $(TYPOS_VERSION)..."
1715
curl -L https://github.com/crate-ci/typos/releases/download/$(TYPOS_VERSION)/typos-$(TYPOS_VERSION)-x86_64-unknown-linux-musl.tar.gz | tar -xz -C $(LOCALBIN) --wildcards '*/typos'
1816
chmod +x $(TYPOS)
19-
20-
$(PYTHON_VENV): | $(LOCALBIN)
21-
python3 -m venv $(PYTHON_VENV)
22-
$(PYTHON_BIN)/pip install --upgrade pip

0 commit comments

Comments
 (0)