Skip to content

Commit 5229f10

Browse files
committed
fix: fix deployments comments
Signed-off-by: Kfir Toledo <[email protected]>
1 parent 3ccba1f commit 5229f10

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

DEVELOPMENT.md

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ This will deploy the entire stack to whatever namespace you chose.
205205
You can test by exposing the inference `Gateway` via port-forward:
206206

207207
```bash
208-
kubectl port-forward service/inference-gateway 8080:80
208+
kubectl port-forward service/inference-gateway 8080:80 -n "${NAMESPACE}"
209209
```
210210

211211
And making requests with `curl`:
@@ -260,22 +260,18 @@ the `git` SHA:
260260
export EPP_TAG=$(git rev-parse HEAD)
261261
```
262262

263-
Build the image:
263+
Build the image and tag the image for your private registry :
264264

265265
```bash
266-
DEV_VERSION=$EPP_TAG make image-build
266+
DEV_VERSION=$EPP_TAG IMAGE_REGISTRY=quay.io/my-id make image-build
267267
```
268268

269-
Tag the image for your private registry and push it:
269+
and push it:
270270

271271
```bash
272-
$CONTAINER_RUNTIME tag quay.io/llm-d/llm-d-gateway-api-inference-extension/epp:$TAG \
273-
<MY_REGISTRY>/<MY_IMAGE>:$EPP_TAG
274-
$CONTAINER_RUNTIME push <MY_REGISTRY>/<MY_IMAGE>:$EPP_TAG
275-
```
272+
IMAGE_REGISTRY=quay.io/my-id make image-push
276273

277-
> **NOTE**: `$CONTAINER_RUNTIME` can be configured or replaced with whatever your
278-
> environment's standard container runtime is (e.g. `podman`, `docker`).
274+
```
279275

280276
Then you can re-deploy the environment with the new changes (don't forget all
281277
the required env vars):

deploy/environments/dev/kubernetes-kgateway/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ resources:
99
- gateway-parameters.yaml
1010

1111
images:
12-
- name: quay.io/llm-d/gateway-api-inference-extension
12+
- name: ghcr.io/llm-d/gateway-api-inference-extension
1313
newName: ${EPP_IMAGE}
1414
newTag: ${EPP_TAG}
1515

scripts/kubernetes-dev-env.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ fi
156156
# Run Helm upgrade/install vllm
157157
echo "INFO: Deploying vLLM Environment in namespace ${NAMESPACE}, ${POOL_NAME}"
158158
helm upgrade --install "$VLLM_HELM_RELEASE_NAME" "$VLLM_CHART_DIR" \
159-
--namespace c3 \
159+
--namespace="$NAMESPACE" \
160160
--set secret.create=true \
161161
--set secret.hfTokenValue="$HF_TOKEN2" \
162162
--set vllm.poolLabelValue="$POOL_NAME" \

0 commit comments

Comments
 (0)