code review

Signed-off-by: Maya Barnea <mayab@il.ibm.com>

Author: mayabar

pkg/plugins/profile/always_disaggr_decider.go

@@ -8,20 +8,20 @@ import (
 )
 
 // compile-time type assertion
-var _ pdDecider = &AlwaysDisaggregationDecider{}
+var _ pdDecider = &alwaysDisaggregationDecider{}
 
 const alwaysDeciderName = "always-disaggregation-decider"
 
 // newAlwaysDisaggregationDecider initializes a new AlwaysDisaggregationDecider and returns its pointer.
-func newAlwaysDisaggregationDecider(_ json.RawMessage) (*AlwaysDisaggregationDecider, error) {
-	return &AlwaysDisaggregationDecider{}, nil
+func newAlwaysDisaggregationDecider(_ json.RawMessage) (*alwaysDisaggregationDecider, error) {
+	return &alwaysDisaggregationDecider{}, nil
 }
 
-// AlwaysDisaggregationDecider handles scheduler profiles for PD.
-type AlwaysDisaggregationDecider struct {
+// alwaysDisaggregationDecider handles scheduler profiles for PD.
+type alwaysDisaggregationDecider struct {
 }
 
 // isDisaggregationRequired checks if disaggregated PD is required for the given request and pod.
-func (d *AlwaysDisaggregationDecider) isDisaggregationRequired(_ context.Context, _ int, _ types.Pod) bool {
+func (d *alwaysDisaggregationDecider) isDisaggregationRequired(_ context.Context, _ int, _ types.Pod) bool {
 	return true
 }

pkg/plugins/profile/pd_profile_handler_test.go

@@ -6,8 +6,6 @@ import (
 	"fmt"
 	"testing"
 
-	"github.com/llm-d/llm-d-inference-scheduler/pkg/common"
-	"github.com/llm-d/llm-d-inference-scheduler/test/utils"
 	"github.com/stretchr/testify/assert"
 	k8stypes "k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend"
@@ -18,6 +16,9 @@ import (
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/framework"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/framework/plugins/multi/prefix"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/types"
+
+	"github.com/llm-d/llm-d-inference-scheduler/pkg/common"
+	"github.com/llm-d/llm-d-inference-scheduler/test/utils"
 )
 
 func TestPdProfileHandlerFactory(t *testing.T) {

pkg/plugins/profile/prefix_disagg_decider.go

@@ -15,7 +15,7 @@ import (
 )
 
 // compile-time type assertion
-var _ pdDecider = &PrefixDisaggregationDecider{}
+var _ pdDecider = &prefixDisaggregationDecider{}
 
 // PrefixDeciderName name of the prefix decider
 const PrefixDeciderName = "prefix-disaggregation-decider"
@@ -45,7 +45,7 @@ func (p prefixDisaggregationDeciderParameters) validate() error {
 }
 
 // NewPdProfileHandler initializes a new PdProfileHandler and returns its pointer.
-func newPrefixDisaggregationDecider(rawParameters json.RawMessage) (*PrefixDisaggregationDecider, error) {
+func newPrefixDisaggregationDecider(rawParameters json.RawMessage) (*prefixDisaggregationDecider, error) {
 	parameters := defaultParams
 
 	if rawParameters != nil {
@@ -58,20 +58,20 @@ func newPrefixDisaggregationDecider(rawParameters json.RawMessage) (*PrefixDisag
 		return nil, err
 	}
 
-	return &PrefixDisaggregationDecider{
+	return &prefixDisaggregationDecider{
 		prefixPluginTypedName: plugins.TypedName{Type: prefix.PrefixCachePluginType, Name: parameters.PluginName},
 		nonCachedTokens:       parameters.NonCachedTokens,
 	}, nil
 }
 
-// PrefixDisaggregationDecider handles scheduler profiles for PD.
-type PrefixDisaggregationDecider struct {
+// prefixDisaggregationDecider handles scheduler profiles for PD.
+type prefixDisaggregationDecider struct {
 	prefixPluginTypedName plugins.TypedName
 	nonCachedTokens       int
 }
 
 // isDisaggregationRequired checks if disaggregated PD is required for the given request and pod.
-func (d *PrefixDisaggregationDecider) isDisaggregationRequired(ctx context.Context, inputTokens int, pod types.Pod) bool {
+func (d *prefixDisaggregationDecider) isDisaggregationRequired(ctx context.Context, inputTokens int, pod types.Pod) bool {
 	logger := log.FromContext(ctx)
 	debugLogger := log.FromContext(ctx).V(logutil.DEBUG)