Skip to content

Commit a7bd2fd

Browse files
committed
Optimized request prefill error messages
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
1 parent 1519a28 commit a7bd2fd

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

pkg/sidecar/proxy/connector_nixlv2.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,19 @@ func (s *Server) runNIXLProtocolV2(w http.ResponseWriter, r *http.Request, prefi
130130
)
131131

132132
if isHTTPError(pw.statusCode) {
133-
s.logger.Error(err, "request failed", "code", pw.statusCode)
133+
s.logger.Error(err, "request failed", "code", pw.statusCode, "body", pw.buffer.String())
134134
prefillSpan.SetStatus(codes.Error, "prefill request failed")
135135
prefillSpan.End()
136+
for key, values := range pw.Header() {
137+
for _, v := range values {
138+
w.Header().Add(key, v)
139+
}
140+
}
136141
w.WriteHeader(pw.statusCode)
142+
_, err := w.Write([]byte(pw.buffer.String()))
143+
if err != nil {
144+
s.logger.Error(err, "failed to send error response to client")
145+
}
137146
return
138147
}
139148
prefillSpan.End()

0 commit comments

Comments
 (0)