build: Upgrade golangci-lint to v2.9.0 and fix lint issues

Signed-off-by: Guangya Liu <gyliu513@gmail.com>

Author: gyliu513

.github/workflows/ci-lint.yaml

@@ -67,7 +67,7 @@ jobs:
       - name: Install golangci-lint without running it
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.1.6
+          version: v2.9.0
           args: "--help"
 
       - name: Run precommit checks with CGo environment

examples/helper/events.go

@@ -37,7 +37,7 @@ func SimulateProduceEvent(ctx context.Context, publisher *Publisher) error {
 	// Use enough tokens to fill 4 blocks (matching PromptHashes count) at blockSize=16.
 	tokenIds := make([]uint32, 64)
 	for i := range tokenIds {
-		tokenIds[i] = uint32(i + 1) //nolint:gosec // i is bounded by len(tokenIds)=64, no overflow
+		tokenIds[i] = uint32(i + 1)
 	}
 
 	// Create event in vLLM msgpack array format: [tag, hashes, parent, tokens, blockSize, loraID, medium, loraName]

pkg/kvevents/subscriber_manager_test.go

@@ -18,6 +18,7 @@ package kvevents_test
 
 import (
 	"context"
+	"fmt"
 	"testing"
 	"time"
 
@@ -199,8 +200,8 @@ func TestSubscriberManager_ConcurrentOperations(t *testing.T) {
 	for i := 0; i < 10; i++ {
 		go func(id int) {
 			defer func() { done <- true }()
-			podID := "default/pod-" + string(rune('0'+id))
-			endpoint := "tcp://10.0.0." + string(rune('0'+id)) + ":5557"
+			podID := fmt.Sprintf("default/pod-%d", id)
+			endpoint := fmt.Sprintf("tcp://10.0.0.%d:5557", id)
 			if err := sm.EnsureSubscriber(ctx, podID, endpoint, "kv@", true); err != nil {
 				t.Errorf("failed to add subscriber %s: %v", podID, err)
 			}

pkg/kvevents/zmq_subscriber_bench_test.go

@@ -70,7 +70,7 @@ func BenchmarkZMQSubscriber_Throughput(b *testing.B) {
 	start := time.Now()
 
 	for i := 0; i < b.N; i++ {
-		binary.BigEndian.PutUint64(seqBytes, uint64(i)) //nolint:gosec // i is a non-negative loop counter, conversion is safe
+		binary.BigEndian.PutUint64(seqBytes, uint64(i))
 		if err := pub.Send(zmq4.NewMsgFrom(topic, seqBytes, payload)); err != nil {
 			b.Fatalf("send failed: %v", err)
 		}

pkg/tokenization/pool_test.go

@@ -161,7 +161,7 @@ func TestPool_WorkerLoop(t *testing.T) {
 			setupMocks: func(mt *MockTokenizer) {
 				for i := range 5 {
 					prompt := "prompt " + string(rune('a'+i))
-					tokens := []uint32{uint32(i), uint32(i + 1)} //nolint:gosec // test code
+					tokens := []uint32{uint32(i), uint32(i + 1)}
 					offsets := []types.Offset{{0, 6}}
 
 					mt.On("Render", prompt).