Skip to content

Commit 12975bf

Browse files
committed
apply review
Signed-off-by: Loic Marchal <lmarchal@redhat.com>
1 parent bfddf5c commit 12975bf

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

pkg/epp/framework/plugins/flowcontrol/usagelimits/priorityholdback/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
A usage limit policy that computes differentiated admission ceilings per priority level. As pool saturation rises, lower-priority traffic is gated first, reserving capacity for higher-priority work.
66

7-
This replaces the default static usage limit policy (which applies a single ceiling to all priorities) with priority-aware stepped gating.
7+
This can be used in place the default static usage limit policy (which applies a single ceiling to all priorities) with priority-aware stepped gating.
88

99
## What It Does
1010

@@ -39,7 +39,7 @@ Use when the numerical spacing between priority values carries meaning and prior
3939

4040
- `strategy` (string, required, no default): Gating algorithm: `"stepwise-spread"` or `"linear-proportional"`.
4141
- `minCeiling` (float64, required, no default): Ceiling for the lowest priority. Must be in `[0.0, 1.0)`.
42-
- `maxCeiling` (float64, required, default: `1.0`): Ceiling for the highest priority. Must be in `(0.0, 1.0]`.
42+
- `maxCeiling` (float64, optional, default: `1.0`): Ceiling for the highest priority. Must be in `(0.0, 1.0]`.
4343

4444
`minCeiling` is required because it determines how aggressively low-priority traffic is gated and there is no universally correct default.
4545

pkg/epp/framework/plugins/flowcontrol/usagelimits/priorityholdback/priority_holdback.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ func (p *priorityHoldbackPolicy) ComputeLimit(_ context.Context, _ float64, prio
8888
if len(priorities) == 1 {
8989
return []float64{p.cMax}
9090
}
91+
// Ceilings are monotonically decreasing as priorities are ordered from highest to lowest per UsageLimitPolicy contract.
92+
// New strategies (e.g. sigmoid/static definition) could require explicit monotizing sweep.
9193
return p.computeFn(p.cMin, p.cMax, priorities)
9294
}
9395

0 commit comments

Comments
 (0)