clean unnecessary function

Signed-off-by: Loic Marchal <lmarchal@redhat.com>

Author: loicmarchal

pkg/epp/flowcontrol/controller/controller.go

@@ -216,7 +216,13 @@ func (fc *FlowController) EnqueueAndWait(
 	flowKey := req.FlowKey()
 	priority := strconv.Itoa(flowKey.Priority)
 	reqBytes := req.ByteSize()
-	sloClass := extractHeader(req, metadata.ObjectiveKey)
+	sloClass := metrics.SLOClassNone
+	if r := req.InferenceRequest(); r != nil {
+		sloClass = fwkrequest.GetHeader(r.Headers, metadata.ObjectiveKey)
+		if sloClass == "" {
+			sloClass = metrics.SLOClassNone
+		}
+	}
 	if sloClass == "" {
 		sloClass = metrics.SLOClassNone
 	}
@@ -342,13 +348,6 @@ func (fc *FlowController) withConnectionWithFallback(
 		return fn(conn, fallback)
 	})
 }
-func extractHeader(req flowcontrol.FlowControlRequest, name string) string {
-	infReq := req.InferenceRequest()
-	if infReq == nil || infReq.Headers == nil {
-		return ""
-	}
-	return fwkrequest.GetHeader(infReq.Headers, name)
-}
 
 // tryDistribution handles a single attempt to select a shard and submit a request.
 // It uses the provided `conn` to access the registry data plane.

pkg/epp/flowcontrol/controller/internal/item.go

@@ -168,9 +168,12 @@ func (fi *FlowItem) finalizeInternal(outcome types.QueueOutcome, err error) {
 		fi.OriginalRequest().ModelName(), fi.OriginalRequest().TargetModelName(),
 		duration)
 
-	sloClass := extractHeader(fi.originalRequest, metadata.ObjectiveKey)
-	if sloClass == "" {
-		sloClass = metrics.SLOClassNone
+	sloClass := metrics.SLOClassNone
+	if req := fi.originalRequest.InferenceRequest(); req != nil {
+		sloClass = request.GetHeader(req.Headers, metadata.ObjectiveKey)
+		if sloClass == "" {
+			sloClass = metrics.SLOClassNone
+		}
 	}
 	metrics.RecordFlowControlSLORequestQueueDuration(
 		sloClass, outcomeStr, fi.originalRequest.InferencePoolName(),
@@ -180,14 +183,6 @@ func (fi *FlowItem) finalizeInternal(outcome types.QueueOutcome, err error) {
 	close(fi.done)
 }
 
-func extractHeader(req flowcontrol.FlowControlRequest, name string) string {
-	infReq := req.InferenceRequest()
-	if infReq == nil || infReq.Headers == nil {
-		return ""
-	}
-	return request.GetHeader(infReq.Headers, name)
-}
-
 // inferOutcome determines the correct QueueOutcome and Error based on the cause of finalization and whether the item
 // was already admitted to a queue.
 func inferOutcome(cause error, isQueued bool) (types.QueueOutcome, error) {