Skip to content

Commit 2d46666

Browse files
committed
fix(flowcontrol): use live item times in test error messages
Read enqueue times from q.items instead of the stale times slice, which reflects pre-removal values. Signed-off-by: RishabhSaini <rishabhsaini01@gmail.com>
1 parent 1dfbb97 commit 2d46666

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

pkg/epp/flowcontrol/framework/plugins/queue/maxminheap_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,14 @@ func TestMaxMinHeap_Remove_CrossSubtreeSwap(t *testing.T) {
109109
}
110110
if isMin {
111111
require.Falsef(t, q.policy.Less(q.items[i], q.items[d]),
112-
"min-level node %d (t=%d) has higher priority than descendant %d (t=%d)",
113-
i, times[i], d, q.items[d].EnqueueTime().Sub(base)/time.Second)
112+
"min-level node %d (t=%v) has higher priority than descendant %d (t=%v)",
113+
i, q.items[i].EnqueueTime().Sub(base)/time.Second,
114+
d, q.items[d].EnqueueTime().Sub(base)/time.Second)
114115
} else {
115116
require.Falsef(t, q.policy.Less(q.items[d], q.items[i]),
116-
"max-level node %d has lower priority than descendant %d", i, d)
117+
"max-level node %d (t=%v) has lower priority than descendant %d (t=%v)",
118+
i, q.items[i].EnqueueTime().Sub(base)/time.Second,
119+
d, q.items[d].EnqueueTime().Sub(base)/time.Second)
117120
}
118121
}
119122
}

0 commit comments

Comments
 (0)