Skip to content

Commit 4a1f879

Browse files
committed
Address review comments.
Signed-off-by: Revital Sur <eres@il.ibm.com>
1 parent 4aceaa2 commit 4a1f879

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

deploy/components/vllm-encode/kustomization.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22
# VLLM Encode Component
33
#
44
# Encoder deployment for multimodal disaggregation scenarios (E/PD, E/P/D).
5-
# Includes a PVC for shared encoder embeddings cache.
6-
# Also referenced by deploy/coordinator/environments/dev/epd-pools/kustomization.yaml.
75
# ------------------------------------------------------------------------------
86
apiVersion: kustomize.config.k8s.io/v1beta1
97
kind: Kustomization
108

119
resources:
1210
- deployment.yaml
13-
# A PVC (pvc.yaml) for shared encoder embeddings cache is NOT included here by default
14-
# - it is added by scenario overlays that need it. The e2e test utils don't support PVC
15-
# creation, and the simulator tolerates missing PVCs. Real vLLM overlays must add the PVC.
11+
# A PVC (pvc.yaml) is only needed by the shared-storage EC connector (ec-example) and
12+
# is NOT included here by default - it is added by scenario overlays that use it. The
13+
# e2e test utils don't support PVC creation, and the simulator tolerates missing PVCs.
14+
# Real vLLM overlays using the shared-storage EC connector must add the PVC.

deploy/components/vllm-prefill/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# VLLM Prefill Component
33
#
44
# Prefill deployment for disaggregation scenarios (P/D, E/P/D).
5-
# Also referenced by deploy/coordinator/environments/dev/epd-pools/kustomization.yaml.
5+
# Also used by the coordinator (deploy/coordinator/environments/dev/epd-pools).
66
# ------------------------------------------------------------------------------
77
apiVersion: kustomize.config.k8s.io/v1beta1
88
kind: Kustomization

0 commit comments

Comments
 (0)