Skip to content

Commit 900a245

Browse files
mayabarmayabar
committed
fix lint
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
1 parent d4469bd commit 900a245

3 files changed

Lines changed: 49 additions & 49 deletions

File tree

‎test/e2e/disruption_test.go‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
9999
gomega.Expect(decodePods).Should(gomega.HaveLen(2))
100100

101101
ginkgo.By("Verifying requests route successfully before disruption")
102-
nsHdr, _, _ := runCompletion(simplePrompt, testutils.ModelName)
102+
nsHdr, _, _ := runCompletion(simplePrompt)
103103
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
104104

105105
targetPod := decodePods[0]
@@ -112,7 +112,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
112112

113113
ginkgo.By("Verifying new requests eventually route to a pod other than the killed one")
114114
gomega.Eventually(func() error {
115-
nsHdr, podHdr, _, err := tryCompletion(simplePrompt, testutils.ModelName)
115+
nsHdr, podHdr, _, err := tryCompletion(simplePrompt)
116116
if err != nil {
117117
return err
118118
}
@@ -133,7 +133,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
133133

134134
ginkgo.By("Verifying requests succeed after recovery")
135135
for range 3 {
136-
nsHdr, _, _ = runCompletion(simplePrompt, testutils.ModelName)
136+
nsHdr, _, _ = runCompletion(simplePrompt)
137137
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
138138
}
139139
})
@@ -185,7 +185,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
185185

186186
ginkgo.By("Verifying requests succeed after recovery")
187187
for range 3 {
188-
nsHdr, _, _ := runCompletion(simplePrompt, testutils.ModelName)
188+
nsHdr, _, _ := runCompletion(simplePrompt)
189189
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
190190
}
191191
})
@@ -205,7 +205,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
205205
gomega.Expect(decodePods).Should(gomega.HaveLen(1))
206206

207207
ginkgo.By("Verifying requests succeed before disruption")
208-
nsHdr, _, _ := runCompletion(simplePrompt, testutils.ModelName)
208+
nsHdr, _, _ := runCompletion(simplePrompt)
209209
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
210210

211211
ginkgo.By("Scaling deployment to zero")
@@ -231,7 +231,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
231231

232232
ginkgo.By("Verifying requests succeed after recovery")
233233
gomega.Eventually(func() string {
234-
nsHdr, _, _ := runCompletion(simplePrompt, testutils.ModelName)
234+
nsHdr, _, _ := runCompletion(simplePrompt)
235235
return nsHdr
236236
}, eppRecoveryTimeout, 2*time.Second).Should(gomega.Equal(nsName))
237237
})
@@ -248,7 +248,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
248248
ginkgo.DeferCleanup(testutils.DeleteObjects, testConfig, epp)
249249

250250
ginkgo.By("Verifying requests succeed before EPP disruption")
251-
nsHdr, _, _ := runCompletion(simplePrompt, testutils.ModelName)
251+
nsHdr, _, _ := runCompletion(simplePrompt)
252252
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
253253

254254
ginkgo.By("Finding EPP pod")
@@ -297,7 +297,7 @@ var _ = ginkgo.Describe("Disruption tests", ginkgo.Ordered, ginkgo.Label("Disrup
297297
ginkgo.DeferCleanup(testutils.DeleteObjects, testConfig, epp)
298298

299299
ginkgo.By("Verifying requests succeed before disruption")
300-
nsHdr, _, _ := runCompletion(simplePrompt, testutils.ModelName)
300+
nsHdr, _, _ := runCompletion(simplePrompt)
301301
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
302302

303303
ginkgo.By("Starting background traffic")

‎test/e2e/e2e_test.go‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
6464
gomega.Expect(prefillPods).Should(gomega.BeEmpty())
6565
gomega.Expect(decodePods).Should(gomega.HaveLen(1))
6666

67-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
67+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
6868
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
6969
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
7070

71-
nsHdr, podHdr, _ = runChatCompletion(simplePrompt, testutils.ModelName)
71+
nsHdr, podHdr, _ = runChatCompletion(simplePrompt)
7272
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
7373
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
7474

@@ -98,32 +98,32 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
9898
gomega.Expect(prefillPods).Should(gomega.HaveLen(prefillReplicas))
9999
gomega.Expect(decodePods).Should(gomega.HaveLen(decodeReplicas))
100100

101-
nsHdr, podHdrCompletion, _ := runCompletion(simplePrompt, testutils.ModelName)
101+
nsHdr, podHdrCompletion, _ := runCompletion(simplePrompt)
102102
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
103103
gomega.Expect(podHdrCompletion).Should(gomega.BeElementOf(decodePods))
104104

105-
nsHdr, podHdrChat, _ := runChatCompletion(simplePrompt, testutils.ModelName)
105+
nsHdr, podHdrChat, _ := runChatCompletion(simplePrompt)
106106
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
107107
gomega.Expect(podHdrChat).Should(gomega.BeElementOf(decodePods))
108108

109109
// Do an extra completion call with a different prompt
110-
nsHdr, podHdr, _ := runCompletion(extraPrompt, testutils.ModelName)
110+
nsHdr, podHdr, _ := runCompletion(extraPrompt)
111111
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
112112
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
113113

114114
// Run completion with the original prompt
115-
nsHdr, podHdr, _ = runCompletion(simplePrompt, testutils.ModelName)
115+
nsHdr, podHdr, _ = runCompletion(simplePrompt)
116116
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
117117
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
118118
gomega.Expect(podHdr).Should(gomega.Equal(podHdrCompletion))
119119

120120
// Do an extra chat completion call with a different prompt
121-
nsHdr, podHdr, _ = runChatCompletion(extraPrompt, testutils.ModelName)
121+
nsHdr, podHdr, _ = runChatCompletion(extraPrompt)
122122
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
123123
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
124124

125125
// Run chat completion with the original prompt
126-
nsHdr, podHdr, _ = runChatCompletion(simplePrompt, testutils.ModelName)
126+
nsHdr, podHdr, _ = runChatCompletion(simplePrompt)
127127
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
128128
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
129129
gomega.Expect(podHdr).Should(gomega.Equal(podHdrChat))
@@ -170,22 +170,22 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
170170
gomega.Expect(decodePods).Should(gomega.HaveLen(decodeReplicas))
171171

172172
// Test regular completion request
173-
nsHdr, podHdrCompletion, _ := runCompletion(simplePrompt, testutils.ModelName)
173+
nsHdr, podHdrCompletion, _ := runCompletion(simplePrompt)
174174
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
175175
gomega.Expect(podHdrCompletion).Should(gomega.BeElementOf(decodePods))
176176

177177
// Test regular chat completion request
178-
nsHdr, podHdrChat, _ := runChatCompletion(simplePrompt, testutils.ModelName)
178+
nsHdr, podHdrChat, _ := runChatCompletion(simplePrompt)
179179
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
180180
gomega.Expect(podHdrChat).Should(gomega.BeElementOf(decodePods))
181181

182182
// Run completion with a different prompt
183-
nsHdr, podHdr, _ := runCompletion(extraPrompt, testutils.ModelName)
183+
nsHdr, podHdr, _ := runCompletion(extraPrompt)
184184
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
185185
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
186186

187187
// Run completion with original prompt (should go to same pod due to prefix cache)
188-
nsHdr, podHdr, _ = runCompletion(simplePrompt, testutils.ModelName)
188+
nsHdr, podHdr, _ = runCompletion(simplePrompt)
189189
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
190190
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
191191
gomega.Expect(podHdr).Should(gomega.Equal(podHdrCompletion))
@@ -347,32 +347,32 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
347347
gomega.Expect(prefillPods).Should(gomega.HaveLen(prefillReplicas))
348348
gomega.Expect(decodePods).Should(gomega.HaveLen(decodeReplicas))
349349

350-
nsHdr, podHdrCompletion, _ := runCompletion(simplePrompt, testutils.ModelName)
350+
nsHdr, podHdrCompletion, _ := runCompletion(simplePrompt)
351351
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
352352
gomega.Expect(podHdrCompletion).Should(gomega.BeElementOf(decodePods))
353353

354-
nsHdr, podHdrChat, _ := runChatCompletion(simplePrompt, testutils.ModelName)
354+
nsHdr, podHdrChat, _ := runChatCompletion(simplePrompt)
355355
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
356356
gomega.Expect(podHdrChat).Should(gomega.BeElementOf(decodePods))
357357

358358
// Do an extra completion call with a different prompt
359-
nsHdr, podHdr, _ := runCompletion(extraPrompt, testutils.ModelName)
359+
nsHdr, podHdr, _ := runCompletion(extraPrompt)
360360
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
361361
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
362362

363363
// Run completion with the original prompt
364-
nsHdr, podHdr, _ = runCompletion(simplePrompt, testutils.ModelName)
364+
nsHdr, podHdr, _ = runCompletion(simplePrompt)
365365
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
366366
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
367367
gomega.Expect(podHdr).Should(gomega.Equal(podHdrCompletion))
368368

369369
// Do an extra chat completion call with a different prompt
370-
nsHdr, podHdr, _ = runChatCompletion(extraPrompt, testutils.ModelName)
370+
nsHdr, podHdr, _ = runChatCompletion(extraPrompt)
371371
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
372372
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
373373

374374
// Run chat completion with the original prompt
375-
nsHdr, podHdr, _ = runChatCompletion(simplePrompt, testutils.ModelName)
375+
nsHdr, podHdr, _ = runChatCompletion(simplePrompt)
376376
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
377377
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
378378
gomega.Expect(podHdr).Should(gomega.Equal(podHdrChat))
@@ -408,11 +408,11 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
408408
gomega.Expect(prefillPods).Should(gomega.BeEmpty())
409409
gomega.Expect(decodePods).Should(gomega.HaveLen(1))
410410

411-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
411+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
412412
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
413413
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
414414

415-
nsHdr, podHdr, _ = runChatCompletion(simplePrompt, testutils.ModelName)
415+
nsHdr, podHdr, _ = runChatCompletion(simplePrompt)
416416
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
417417
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
418418

@@ -442,7 +442,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
442442
gomega.Expect(prefillDecodePods).Should(gomega.HaveLen(decodeReplicas))
443443

444444
// Text request: encode stage skipped, routed directly to a prefill-decode pod
445-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
445+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
446446
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
447447
gomega.Expect(podHdr).Should(gomega.BeElementOf(prefillDecodePods))
448448

@@ -518,7 +518,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
518518
gomega.Expect(decodePods).Should(gomega.HaveLen(decodeReplicas))
519519

520520
// Text request: encode stage skipped, prefill triggered by prefix-based-pd-decider
521-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
521+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
522522
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
523523
gomega.Expect(podHdr).Should(gomega.BeElementOf(decodePods))
524524

@@ -599,12 +599,12 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
599599
gomega.Expect(epdPods).Should(gomega.HaveLen(replicas))
600600

601601
// Text completion: encode skipped, routes to decode profile -> single deployment
602-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
602+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
603603
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
604604
gomega.Expect(podHdr).Should(gomega.Equal(epdPods[0]))
605605

606606
// Text chat completion: same routing as above
607-
nsHdr, podHdr, _ = runChatCompletion(simplePrompt, testutils.ModelName)
607+
nsHdr, podHdr, _ = runChatCompletion(simplePrompt)
608608
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
609609
gomega.Expect(podHdr).Should(gomega.Equal(epdPods[0]))
610610

@@ -657,7 +657,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
657657
gomega.Expect(decodePods).Should(gomega.HaveLen(1))
658658

659659
for range 5 {
660-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
660+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
661661
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
662662
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
663663
}
@@ -681,18 +681,18 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
681681
gomega.Expect(decodePods).Should(gomega.HaveLen(1))
682682

683683
// Test completions
684-
nsHdr, podHdr, _ := runCompletion(simplePrompt, testutils.ModelName)
684+
nsHdr, podHdr, _ := runCompletion(simplePrompt)
685685
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
686686
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
687687

688688
// Test chat completions
689-
nsHdr, podHdr, _ = runChatCompletion(simplePrompt, testutils.ModelName)
689+
nsHdr, podHdr, _ = runChatCompletion(simplePrompt)
690690
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
691691
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
692692

693693
// Repeat to verify prefix cache affinity with pre-tokenized prompts
694694
for range 3 {
695-
nsHdr, podHdr, _ = runCompletion(simplePrompt, testutils.ModelName)
695+
nsHdr, podHdr, _ = runCompletion(simplePrompt)
696696
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
697697
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
698698
}
@@ -716,7 +716,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
716716

717717
var nsHdr, podHdr string
718718
for range 5 {
719-
nsHdr, podHdr, _ = runCompletion(simplePrompt, testutils.ModelName)
719+
nsHdr, podHdr, _ = runCompletion(simplePrompt)
720720
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
721721
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
722722
}
@@ -730,7 +730,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
730730
var scaledNsHdr, scaledPodHdr string
731731
// Run inference multiple times until one is scheduled on the new pod
732732
for range 30 {
733-
scaledNsHdr, scaledPodHdr, _ = runCompletion(extraPrompt, testutils.ModelName)
733+
scaledNsHdr, scaledPodHdr, _ = runCompletion(extraPrompt)
734734
gomega.Expect(scaledNsHdr).Should(gomega.Equal(nsName))
735735
gomega.Expect(scaledPodHdr).Should(gomega.BeElementOf(scaledUpDecodePods))
736736
if scaledPodHdr != podHdr {
@@ -748,7 +748,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
748748

749749
// Run multiple times and insure that they are scheduled on the remaining pod
750750
for range 5 {
751-
nsHdr, podHdr, _ = runCompletion(simplePrompt, testutils.ModelName)
751+
nsHdr, podHdr, _ = runCompletion(simplePrompt)
752752
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
753753
gomega.Expect(podHdr).Should(gomega.Equal(scaledDownDecodePods[0]))
754754
}
@@ -770,15 +770,15 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
770770
gomega.Expect(prefillPods).Should(gomega.BeEmpty())
771771
gomega.Expect(decodePods).Should(gomega.HaveLen(1))
772772

773-
nsHdr, podHdr, portHdr := runCompletion(simplePrompt, testutils.ModelName)
773+
nsHdr, podHdr, portHdr := runCompletion(simplePrompt)
774774
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
775775
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
776776

777777
var parallelNsHdr, parallelPodHdr, parallelPortHdr string
778778

779779
// Run inference multiple times until one is scheduled on the other port
780780
for range 30 {
781-
parallelNsHdr, parallelPodHdr, parallelPortHdr = runCompletion(extraPrompt, testutils.ModelName)
781+
parallelNsHdr, parallelPodHdr, parallelPortHdr = runCompletion(extraPrompt)
782782
gomega.Expect(parallelNsHdr).Should(gomega.Equal(nsName))
783783
gomega.Expect(parallelPodHdr).Should(gomega.Equal(decodePods[0]))
784784
if parallelPortHdr != portHdr {
@@ -787,13 +787,13 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
787787
}
788788
gomega.Expect(parallelPortHdr).ShouldNot(gomega.Equal(portHdr))
789789

790-
nsHdr, podHdr, portHdr = runChatCompletion(simplePrompt, testutils.ModelName)
790+
nsHdr, podHdr, portHdr = runChatCompletion(simplePrompt)
791791
gomega.Expect(nsHdr).Should(gomega.Equal(nsName))
792792
gomega.Expect(podHdr).Should(gomega.Equal(decodePods[0]))
793793

794794
// Run inference multiple times until one is scheduled on the other port
795795
for range 30 {
796-
parallelNsHdr, parallelPodHdr, parallelPortHdr = runChatCompletion(extraPrompt, testutils.ModelName)
796+
parallelNsHdr, parallelPodHdr, parallelPortHdr = runChatCompletion(extraPrompt)
797797
gomega.Expect(parallelNsHdr).Should(gomega.Equal(nsName))
798798
gomega.Expect(parallelPodHdr).Should(gomega.Equal(decodePods[0]))
799799
if parallelPortHdr != portHdr {

‎test/e2e/requests_test.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ func doPost(path, body string, extraHeaders map[string]string) (string, string,
4848
return resp.Header.Get("x-inference-namespace"), resp.Header.Get("x-inference-pod"), respBody
4949
}
5050

51-
func runCompletion(prompt string, theModel openai.CompletionNewParamsModel) (string, string, string) {
51+
func runCompletion(prompt string) (string, string, string) {
5252
var httpResp *http.Response
5353

5454
completionParams := openai.CompletionNewParams{
5555
Prompt: openai.CompletionNewParamsPromptUnion{
5656
OfString: openai.String(prompt),
5757
},
58-
Model: theModel,
58+
Model: testutils.ModelName,
5959
}
6060

6161
ginkgo.By(fmt.Sprintf("Sending Completion Request: (port %s) %#v", port, completionParams))
@@ -74,11 +74,11 @@ func runCompletion(prompt string, theModel openai.CompletionNewParamsModel) (str
7474

7575
// tryCompletion is like runCompletion but returns an error instead of asserting,
7676
// intended for use inside Eventually blocks where transient failures are acceptable.
77-
func tryCompletion(prompt string, theModel openai.CompletionNewParamsModel) (string, string, string, error) {
77+
func tryCompletion(prompt string) (string, string, string, error) {
7878
var httpResp *http.Response
7979
completionParams := openai.CompletionNewParams{
8080
Prompt: openai.CompletionNewParamsPromptUnion{OfString: openai.String(prompt)},
81-
Model: theModel,
81+
Model: testutils.ModelName,
8282
}
8383
resp, err := newOpenAIClient().Completions.New(
8484
testConfig.Context,
@@ -99,14 +99,14 @@ func tryCompletion(prompt string, theModel openai.CompletionNewParamsModel) (str
9999
return ns, pod, p, nil
100100
}
101101

102-
func runChatCompletion(prompt, modelName string) (string, string, string) {
102+
func runChatCompletion(prompt string) (string, string, string) {
103103
var httpResp *http.Response
104104

105105
params := openai.ChatCompletionNewParams{
106106
Messages: []openai.ChatCompletionMessageParamUnion{
107107
openai.UserMessage(prompt),
108108
},
109-
Model: modelName,
109+
Model: testutils.ModelName,
110110
}
111111
resp, err := newOpenAIClient().Chat.Completions.New(testConfig.Context, params, option.WithResponseInto(&httpResp))
112112
gomega.Expect(err).ShouldNot(gomega.HaveOccurred())

0 commit comments

Comments
 (0)