Skip to content

Commit 936125c

Browse files
committed
Update comments.
Signed-off-by: Revital Sur <eres@il.ibm.com>
1 parent 114fd49 commit 936125c

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

test/coordinator/e2e/coordinator/e2e_suite_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,8 @@ var _ = ginkgo.BeforeSuite(func() {
133133

134134
rendererObjects = createRenderer()
135135

136-
// Coordinator and EPP Services, ServiceAccounts, and RoleBindings are created
137-
// once and kept stable across specs so Envoy's STRICT_DNS clusters never have
138-
// to re-resolve a rotated ClusterIP.
136+
// Coordinator and EPP Services/RBAC are created once and kept stable across
137+
// specs (see createStableInfra).
139138
stableInfraObjects = createStableInfra()
140139
})
141140

test/coordinator/e2e/coordinator/setup_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ func createCoordinator(config string) []string {
179179
objects[0] = "ConfigMap/llm-d-coordinator-config"
180180

181181
docs := e2eutil.RunKustomize(coordinatorComponentDir)
182-
// The Service and ServiceAccount are created once by createStableInfra so the
183-
// ClusterIP is stable across specs; recreate only the Deployment per spec.
182+
// Service and ServiceAccount are created once by createStableInfra; recreate
183+
// only the Deployment per spec.
184184
docs = e2eutil.FilterKinds(docs, "ConfigMap", "Service", "ServiceAccount")
185185
docs = e2eutil.SubstituteMany(docs, coordinatorSubstitutions())
186186
docs = e2eutil.RemoveEmptyArgs(docs)
@@ -194,9 +194,9 @@ func createCoordinator(config string) []string {
194194
// waitForCoordinatorReady polls /readyz through Envoy until it returns 200,
195195
// confirming the freshly recreated coordinator pod is reachable through the
196196
// gateway before the test sends its request. The gateway Service is stable
197-
// across specs (see createStableInfra), so this waits for the new pod to
198-
// appear behind it, not for Envoy to re-resolve a rotated ClusterIP.
199-
// (podsInDeploymentsReady already confirms the coordinator pod itself is ready.)
197+
// across specs (see createStableInfra), so this waits only for the new pod to
198+
// appear behind it. (podsInDeploymentsReady already confirms the coordinator
199+
// pod itself is ready.)
200200
func waitForCoordinatorReady() {
201201
ginkgo.By("Waiting for coordinator to be reachable via gateway")
202202
gomega.Eventually(func() bool {

0 commit comments

Comments
 (0)