Strip the diagnostics (Envoy access log, failure/end-of-spec dumps, dumpEnvoyClusters)

Signed-off-by: Revital Sur <eres@il.ibm.com>

Author: revit13

test/coordinator/e2e/coordinator/coordinator_test.go

@@ -127,12 +127,17 @@ func runCoordinatorPipeline(body []byte, expectedSteps []string, expectedImages
 		if !ginkgo.CurrentSpecReport().Failed() && !printCoordinatorLogs {
 			return
 		}
-		dumpDeploymentLogs(nsName, "llm-d-coordinator", "coordinator")
-		dumpDeploymentLogs(nsName, eppName+"-encode", "epp")
-		dumpDeploymentLogs(nsName, eppName+"-prefill", "epp")
-		dumpDeploymentLogs(nsName, eppName+"-decode", "epp")
-		dumpDeploymentLogs(nsName, "envoy", "envoy")
-		dumpEnvoyClusters(nsName)
+		args := []string{"logs", "deployment/llm-d-coordinator",
+			"-c", "coordinator", "--namespace=" + nsName}
+		if k8sContext != "" {
+			args = append(args, "--context="+k8sContext)
+		}
+		out, err := exec.Command("kubectl", args...).CombinedOutput()
+		if err != nil {
+			fmt.Fprintf(ginkgo.GinkgoWriter, "\n--- coordinator logs (kubectl error: %v) ---\n%s\n---\n", err, string(out))
+		} else {
+			fmt.Fprintf(ginkgo.GinkgoWriter, "\n--- coordinator logs ---\n%s\n---\n", string(out))
+		}
 	})
 
 	// Pools first so each EPP can resolve its --pool-name.
@@ -175,47 +180,6 @@ func runCoordinatorPipeline(body []byte, expectedSteps []string, expectedImages
 		"coordinator returned non-200: body=%s", string(raw))
 	gomega.Expect(raw).NotTo(gomega.BeEmpty(), "coordinator returned empty body")
 	verifyCoordinatorSteps(nsName, expectedSteps, expectedImages, true, true)
-
-	// Diagnostic: dump the coordinator logs once the request has completed. The
-	// per-step timestamps show when the request reached the coordinator (relative
-	// to when it was sent) and how long each pipeline step took, so we can tell
-	// late-arrival (gateway) from slow processing (pipeline). Also dump Envoy's
-	// access log so each request's gateway view (code/flags/cluster/upstream) is
-	// visible even on green runs, as a baseline to compare against a failure.
-	dumpDeploymentLogs(nsName, "llm-d-coordinator", "coordinator")
-	dumpDeploymentLogs(nsName, "envoy", "envoy")
-}
-
-// dumpDeploymentLogs writes a deployment's container logs to the Ginkgo output.
-// A kubectl error is reported inline rather than failing the spec.
-func dumpDeploymentLogs(nsName, deployment, container string) {
-	args := []string{"logs", "deployment/" + deployment, "-c", container, "--namespace=" + nsName}
-	if k8sContext != "" {
-		args = append(args, "--context="+k8sContext)
-	}
-	out, err := exec.Command("kubectl", args...).CombinedOutput()
-	if err != nil {
-		fmt.Fprintf(ginkgo.GinkgoWriter, "\n--- %s logs (kubectl error: %v) ---\n%s\n---\n", deployment, err, string(out))
-		return
-	}
-	fmt.Fprintf(ginkgo.GinkgoWriter, "\n--- %s logs ---\n%s\n---\n", deployment, string(out))
-}
-
-// dumpEnvoyClusters writes Envoy's admin /clusters (resolved endpoints and health
-// per cluster) to the Ginkgo output. Best-effort; yields nothing if the envoy
-// image lacks a usable HTTP client.
-func dumpEnvoyClusters(nsName string) {
-	args := []string{"exec", "deployment/envoy", "-c", "envoy", "--namespace=" + nsName}
-	if k8sContext != "" {
-		args = append(args, "--context="+k8sContext)
-	}
-	args = append(args, "--", "curl", "-s", "http://localhost:19000/clusters")
-	out, err := exec.Command("kubectl", args...).CombinedOutput()
-	if err != nil {
-		fmt.Fprintf(ginkgo.GinkgoWriter, "\n--- envoy /clusters (kubectl error: %v) ---\n%s\n---\n", err, string(out))
-		return
-	}
-	fmt.Fprintf(ginkgo.GinkgoWriter, "\n--- envoy /clusters ---\n%s\n---\n", string(out))
 }
 
 // verifyCoordinatorSteps fetches the coordinator pod logs and asserts that

test/coordinator/e2e/coordinator/testdata/envoy.yaml

@@ -80,13 +80,6 @@ data:
                     "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                     stat_prefix: http-8081
                     preserve_external_request_id: true
-                    access_log:
-                      - name: envoy.access_loggers.stdout
-                        typed_config:
-                          "@type": type.googleapis.com/envoy.extensions.access_loggers.stream.v3.StdoutAccessLog
-                          log_format:
-                            text_format_source:
-                              inline_string: "[envoy] %REQ(:METHOD)% %REQ(:PATH)% code=%RESPONSE_CODE% flags=%RESPONSE_FLAGS% cluster=%UPSTREAM_CLUSTER% upstream=%UPSTREAM_HOST% epp-phase=%REQ(EPP-PHASE)% id=%REQ(X-REQUEST-ID)% dur=%DURATION%\n"
                     route_config:
                       name: vllm
                       virtual_hosts: