Skip to content

Commit ba1a1ab

Browse files
committed
Minor changes.
Signed-off-by: Revital Sur <eres@il.ibm.com>
1 parent 6a5685f commit ba1a1ab

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

test/coordinator/e2e/coordinator/setup_test.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ func createCRDs() {
8080
_ = testutils.CreateObjsFromYaml(testConfig, gieCRDs, "")
8181
}
8282

83-
// createEndPointPicker creates the scheduling ConfigMap and EPP Deployment (plus
84-
// its ServiceAccount, RoleBinding, and Service) for the given phase from the
85-
// supplied EPP config and waits for the EPP Deployment to become ready. Returns
86-
// the created object ids for cleanup.
83+
// createEndPointPicker creates the scheduling ConfigMap and EPP Deployment for
84+
// the given phase from the supplied EPP config and waits for the EPP Deployment
85+
// to become ready. Its ServiceAccount, RoleBinding, and Service are created once
86+
// by createStableInfra. Returns the created object ids for cleanup.
8787
func createEndPointPicker(phase, config string) []string {
8888
manifest := map[string]string{
8989
"encode": encodeEPPManifest,
@@ -156,8 +156,8 @@ func createModelServers(encodeReplicas, prefillReplicas, decodeReplicas int) []s
156156
}
157157

158158
// createCoordinator builds the coordinator ConfigMap from the given pipeline
159-
// config, deploys the coordinator component (Deployment + Service + SA), and
160-
// waits for readiness.
159+
// config, deploys the coordinator Deployment, and waits for readiness. Its
160+
// Service and ServiceAccount are created once by createStableInfra.
161161
func createCoordinator(config string) []string {
162162
nsName := getNamespace()
163163
coordinatorYAML := e2eutil.SubstituteMany([]string{config}, map[string]string{
@@ -233,9 +233,7 @@ func applyManifest(path string, subs map[string]string, excludeKinds ...string)
233233
docs := testutils.ReadYaml(path)
234234
docs = e2eutil.SubstituteMany(docs, subs)
235235
docs = e2eutil.RemoveEmptyArgs(docs)
236-
if len(excludeKinds) > 0 {
237-
docs = e2eutil.FilterKinds(docs, excludeKinds...)
238-
}
236+
docs = e2eutil.FilterKinds(docs, excludeKinds...)
239237
return testutils.CreateObjsFromYaml(testConfig, docs, getNamespace())
240238
}
241239

0 commit comments

Comments
 (0)