Skip to content

Commit c953c4b

Browse files
authored
ci: aggregate matrix job results into single status checks (#2028)
Add e2e-image-common-status, e2e-image-router-status, and e2e-router-status jobs that roll up their matrix job's result. Individual matrix legs (e.g. e2e-router (pd-shared-storage-disagg)) cannot be named as required status checks without listing every suite, so a failing leg outside the required list does not block merge. Requiring the aggregator job instead is stable across matrix changes. Fixes #2027 Signed-off-by: Etai Lev Ran <elevran@gmail.com>
1 parent 7f67e65 commit c953c4b

1 file changed

Lines changed: 42 additions & 0 deletions

File tree

.github/workflows/ci-pr-checks.yaml

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Matrix jobs (e2e-image-common, e2e-image-router, e2e-router) are each
2+
# followed by a *-status job that aggregates their result, since GitHub
3+
# required status checks cannot reference individual matrix legs.
14
name: CI - Test
25

36
on:
@@ -256,6 +259,19 @@ jobs:
256259
retention-days: 1
257260
compression-level: 0
258261

262+
e2e-image-common-status:
263+
needs: e2e-image-common
264+
if: always()
265+
runs-on: ubuntu-latest
266+
steps:
267+
- name: Check e2e-image-common result
268+
run: |
269+
result="${{ needs.e2e-image-common.result }}"
270+
if [[ "$result" != "success" && "$result" != "skipped" ]]; then
271+
echo "::error::e2e-image-common failed for at least one matrix image"
272+
exit 1
273+
fi
274+
259275
e2e-image-router:
260276
needs: check-changes
261277
if: ${{ needs.check-changes.outputs.src == 'true' }}
@@ -306,6 +322,19 @@ jobs:
306322
retention-days: 1
307323
compression-level: 0
308324

325+
e2e-image-router-status:
326+
needs: e2e-image-router
327+
if: always()
328+
runs-on: ubuntu-latest
329+
steps:
330+
- name: Check e2e-image-router result
331+
run: |
332+
result="${{ needs.e2e-image-router.result }}"
333+
if [[ "$result" != "success" && "$result" != "skipped" ]]; then
334+
echo "::error::e2e-image-router failed for at least one matrix image"
335+
exit 1
336+
fi
337+
309338
e2e-router:
310339
needs:
311340
- check-changes
@@ -393,3 +422,16 @@ jobs:
393422
PULL_VLLM_RENDER_IMAGE: "false"
394423
HF_TOKEN: ${{ secrets.HF_TOKEN }}
395424
run: make test-e2e-run
425+
426+
e2e-router-status:
427+
needs: e2e-router
428+
if: always()
429+
runs-on: ubuntu-latest
430+
steps:
431+
- name: Check e2e-router result
432+
run: |
433+
result="${{ needs.e2e-router.result }}"
434+
if [[ "$result" != "success" && "$result" != "skipped" ]]; then
435+
echo "::error::e2e-router failed for at least one matrix suite"
436+
exit 1
437+
fi

0 commit comments

Comments
 (0)