ci: publish CRD manifests to release assets#1713
Merged
Merged
Conversation
github-actions
Bot
added
the
size/M
liu-cong
marked this pull request as ready for review
June 22, 2026 21:30
ahg-g
previously approved these changes
Jun 22, 2026
Collaborator
|
Do we need to patch against the release branch? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a release-artifact generation pathway for CRD manifests and updates the CRD kustomization layout so release artifacts can be built from config/crd/bases (excluding third-party/upstream CRDs) and uploaded as GitHub Release assets.
Changes:
- Add a
make artifactstarget to generatemanifests.yaml, plus split outputs intov1-manifests.yamlandexperimental-manifests.yaml. - Restructure
config/crdkustomization to reference abases/kustomization directory rather than enumerating local CRD files directly. - Extend the release workflow with an
upload-artifactsjob that builds and uploads non-empty manifest files to the Release.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Makefile | Adds a release artifact build target for CRD manifests and splits v1 vs non-v1 outputs. |
| config/crd/kustomization.yaml | Updates the CRD root kustomization to include the bases directory. |
| config/crd/bases/kustomization.yaml | Introduces a bases kustomization that lists local CRD YAML resources. |
| .github/workflows/ci-release.yaml | Adds a job to generate and upload CRD manifest artifacts to GitHub Releases. |
Member
Author
I will cherry pick this to release branch. |
Closed
liu-cong
force-pushed
the
crd-release-assets-main
branch
from
June 22, 2026 21:40
72b71a3 to
3ba3637
Compare
Signed-off-by: Cong Liu <conliu@google.com>
liu-cong
force-pushed
the
crd-release-assets-main
branch
from
June 22, 2026 21:47
3ba3637 to
a6b6c35
Compare
ahg-g
approved these changes
Jun 22, 2026
liu-cong
added a commit
that referenced
this pull request
Jun 23, 2026
Signed-off-by: Cong Liu <conliu@google.com>
ahg-g
pushed a commit
that referenced
this pull request
Jun 26, 2026
* release: set LATENCY_PREDICTOR_TAG to v0.8.0-rc.1 Signed-off-by: Cong Liu <conliu@google.com> * deps(go): bump llm-d-kv-cache to v0.9.0 (#1691) Update github.com/llm-d/llm-d-kv-cache from v0.9.0-rc.1 to the released v0.9.0. Signed-off-by: Maroon Ayoub <mayoub@redhat.com> Signed-off-by: Cong Liu <conliu@google.com> * fix(chart): update latency predictor image path to match subchart nesting (#1683) Signed-off-by: weizhoublue <weizhou.lan@daocloud.io> Signed-off-by: Cong Liu <conliu@google.com> * consume official latency predictor v0.8 release (#1729) Signed-off-by: greg pereira <grpereir@redhat.com> * ci: add artifacts target and upload-artifacts job for CRDs (#1713) Signed-off-by: Cong Liu <conliu@google.com> * fix: bump golang.org/x/crypto to v0.52.0 to resolve Trivy CVEs (#1720) Bumps golang.org/x/crypto from v0.51.0 to v0.52.0 to fix 8 HIGH severity CVEs (CVE-2026-39827 through CVE-2026-46598) that caused the sidecar image Trivy scan to fail in CI. Signed-off-by: Cong Liu <conliu@google.com> * docs: assemble release notes for v0.9.0 Signed-off-by: llm-d-router-release-notes[bot] <287676111+llm-d-router-release-notes[bot]@users.noreply.github.com> * revert the latency predictor change Signed-off-by: Cong Liu <conliu@google.com> * Update push-chart.sh Signed-off-by: Cong Liu <conliu@google.com> --------- Signed-off-by: Cong Liu <conliu@google.com> Signed-off-by: Maroon Ayoub <mayoub@redhat.com> Signed-off-by: weizhoublue <weizhou.lan@daocloud.io> Signed-off-by: greg pereira <grpereir@redhat.com> Signed-off-by: llm-d-router-release-notes[bot] <287676111+llm-d-router-release-notes[bot]@users.noreply.github.com> Co-authored-by: Cong Liu <conliu@google.com> Co-authored-by: Maroon Ayoub <maroon.ayoub@ibm.com> Co-authored-by: weizhoublue <45163302+weizhoublue@users.noreply.github.com> Co-authored-by: Greg Pereira <grpereir@redhat.com> Co-authored-by: llm-d-router-release-notes[bot] <287676111+llm-d-router-release-notes[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a release artifacts generation rule and configures the release workflow to build and attach
experimental-manifests.yaml(as well asv1-manifests.yamlandmanifests.yamlif they are not empty) to release assets.Instead of modifying the kustomization files, this PR introduces a
select(.spec.group == "llm-d.ai")filter in the Makefile to cleanly select only local CRDs for build/release, keeping the kustomization root untouched and clean.E2E Test Results
The release workflow changes have been successfully verified on a personal fork (
liu-cong/llm-d-router):experimental-manifests.yamlmanifests.yaml