Skip to content

Make Docker build context explicit in reusable image build action#1719

Closed
liu-cong with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-release-sidecar-build-failure
Closed

Make Docker build context explicit in reusable image build action#1719
liu-cong with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-release-sidecar-build-failure

Conversation

Copilot AI commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Release image builds were relying on docker/build-push-action's implicit context resolution, which can fall back to a git URL in release runs. This change makes the reusable action always build from the checked-out workspace so sidecar and EPP image builds use a stable local context.

  • Build context

    • Set context: . in .github/actions/docker-build-and-push/action.yml.
    • Removes reliance on BuildKit inferring the source as https://github.com/llm-d/llm-d-router.git#<sha> during release execution.
  • Release image behavior preserved

    • Keeps existing image tags, cache configuration, build args, and platform selection unchanged.
    • Applies uniformly to both no-push tarball exports and pushed multi-arch builds because both paths use the same reusable action.
- name: Build image
  uses: docker/build-push-action@v6
  with:
    context: .
    file: ${{ inputs.docker-file }}
    push: ${{ inputs.push == 'true' }}

Copilot AI changed the title [WIP] Fix release-sidecar build failure in llm-d-router Make release image builds use explicit local Docker context Jun 22, 2026
Copilot AI requested a review from liu-cong June 22, 2026 23:50
Copilot AI changed the title Make release image builds use explicit local Docker context Make Docker build context explicit in reusable image build action Jun 22, 2026
@github-actions github-actions Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2026
@liu-cong liu-cong closed this Jun 23, 2026
@ahg-g
ahg-g deleted the copilot/fix-release-sidecar-build-failure branch June 26, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants