From 0dbabb0c2b79c9843cdc4b64a5a3670458f9544a Mon Sep 17 00:00:00 2001 From: Wen Zhou Date: Tue, 23 Jun 2026 13:00:37 +0200 Subject: [PATCH] chore: switch default vllm port from 8001 to 8200 for sidecar - remove explicitly config to use 8200 in deployment and test - keep local dev test with 8001 Signed-off-by: Wen Zhou --- deploy/components/vllm-decode/deployment.yaml | 1 - deploy/environments/dev/e-p-d/patch-decode.yaml | 1 - deploy/environments/dev/e-pd/patch-decode.yaml | 1 - deploy/environments/dev/p-d/patch-decode.yaml | 1 - pkg/sidecar/proxy/options.go | 2 +- pkg/sidecar/proxy/options_test.go | 6 +++--- test/sidecar/config/nixl/qwen-decoder-pod.yaml | 1 - 7 files changed, 4 insertions(+), 9 deletions(-) diff --git a/deploy/components/vllm-decode/deployment.yaml b/deploy/components/vllm-decode/deployment.yaml index fb93fa583f..69920f8e0e 100644 --- a/deploy/components/vllm-decode/deployment.yaml +++ b/deploy/components/vllm-decode/deployment.yaml @@ -25,7 +25,6 @@ spec: imagePullPolicy: IfNotPresent args: - "--port=8000" - - "--vllm-port=8200" - "--secure-proxy=false" - "--data-parallel-size=${VLLM_DATA_PARALLEL_SIZE}" ports: diff --git a/deploy/environments/dev/e-p-d/patch-decode.yaml b/deploy/environments/dev/e-p-d/patch-decode.yaml index 75ca5af866..5b1e6d43ad 100644 --- a/deploy/environments/dev/e-p-d/patch-decode.yaml +++ b/deploy/environments/dev/e-p-d/patch-decode.yaml @@ -12,7 +12,6 @@ spec: - name: routing-sidecar args: - "--port=8000" - - "--vllm-port=8200" - "--kv-connector=${KV_CONNECTOR_TYPE}" - "--ec-connector=${EC_CONNECTOR_TYPE}" - "--secure-proxy=false" diff --git a/deploy/environments/dev/e-pd/patch-decode.yaml b/deploy/environments/dev/e-pd/patch-decode.yaml index 307c7d4595..177d03d416 100644 --- a/deploy/environments/dev/e-pd/patch-decode.yaml +++ b/deploy/environments/dev/e-pd/patch-decode.yaml @@ -12,7 +12,6 @@ spec: - name: routing-sidecar args: - "--port=8000" - - "--vllm-port=8200" - "--ec-connector=${EC_CONNECTOR_TYPE}" - "--secure-proxy=false" - "--data-parallel-size=${VLLM_DATA_PARALLEL_SIZE}" diff --git a/deploy/environments/dev/p-d/patch-decode.yaml b/deploy/environments/dev/p-d/patch-decode.yaml index e2d1029643..8c9948b978 100644 --- a/deploy/environments/dev/p-d/patch-decode.yaml +++ b/deploy/environments/dev/p-d/patch-decode.yaml @@ -12,7 +12,6 @@ spec: - name: routing-sidecar args: - "--port=8000" - - "--vllm-port=8200" - "--kv-connector=${CONNECTOR_TYPE}" - "--mooncake-bootstrap-port=8000" - "--secure-proxy=false" diff --git a/pkg/sidecar/proxy/options.go b/pkg/sidecar/proxy/options.go index d13c3b07a1..ae95edcc14 100644 --- a/pkg/sidecar/proxy/options.go +++ b/pkg/sidecar/proxy/options.go @@ -89,7 +89,7 @@ const ( // Defaults defaultPort = "8000" - defaultVLLMPort = "8001" + defaultVLLMPort = "8200" defaultDataParallelSize = 1 defaultMooncakeBootstrapPort = 8998 diff --git a/pkg/sidecar/proxy/options_test.go b/pkg/sidecar/proxy/options_test.go index 80c8195be7..332b094f7e 100644 --- a/pkg/sidecar/proxy/options_test.go +++ b/pkg/sidecar/proxy/options_test.go @@ -43,7 +43,7 @@ func createConfigWithValidYAML(t *testing.T) string { t.Helper() return writeTempYAML(t, "valid.yaml", fmt.Sprintf(` port: 8100 -vllm-port: 8200 +vllm-port: 8001 data-parallel-size: 5 kv-connector: %q connector: %q @@ -74,7 +74,7 @@ func createConfigWithUnknownKeys(t *testing.T) string { t.Helper() return writeTempYAML(t, "valid.yaml", ` port: 8100 -vllm-port: 8200 +vllm-port: 8001 unknown-key: 1001 `) } @@ -183,7 +183,7 @@ func TestSidecarConfiguration(t *testing.T) { }, expected: func(o *Options) { o.Port = "8100" - o.vllmPort = "8200" + o.vllmPort = "8001" o.DataParallelSize = 5 o.MaxIdleConnsPerHost = 300 o.MooncakeBootstrapPort = 9000 diff --git a/test/sidecar/config/nixl/qwen-decoder-pod.yaml b/test/sidecar/config/nixl/qwen-decoder-pod.yaml index e575c0b6e7..e416eeb7d4 100644 --- a/test/sidecar/config/nixl/qwen-decoder-pod.yaml +++ b/test/sidecar/config/nixl/qwen-decoder-pod.yaml @@ -25,7 +25,6 @@ spec: runAsNonRoot: true args: - "-port=8000" - - "-vllm-port=8200" - "-connector=nixlv2" - "-v=6" ports: