Skip to content

Commit 2d8e765

Browse files
committed
fix: change LLM_D_RELEASE default to main for GA InferencePool API
The previous attempt set LLM_D_RELEASE in ci-benchmark.yaml, but issue_comment-triggered workflows always use the workflow YAML from the default branch — not the PR branch. The env var never took effect. Change the default in deploy/install.sh instead (v0.3.0 → main), which IS executed from the PR checkout. llm-d main uses inferencepool chart v1.4.0 which creates InferencePool with the GA API group (inference.networking.k8s.io/v1) that Istio 1.29+ expects. The old v0.3.0 default used chart v1.0.1 with the alpha API group (inference.networking.x-k8s.io/v1alpha2), which Istio ignores — causing Gateway HTTP 500 errors. Made-with: Cursor
1 parent 1fbe6e1 commit 2d8e765

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

.github/workflows/ci-benchmark.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -545,9 +545,6 @@ jobs:
545545
INSTALL_GATEWAY_CTRLPLANE: "false"
546546
E2E_TESTS_ENABLED: "true"
547547
NAMESPACE_SCOPED: "false"
548-
# Use main branch of llm-d/llm-d for inferencepool chart v1.2.1 (GA API support);
549-
# v0.3.0 default uses alpha API which Istio 1.29+ does not route through ext_proc.
550-
LLM_D_RELEASE: main
551548
LLMD_NS: ${{ env.LLMD_NAMESPACE }}
552549
WVA_NS: ${{ env.WVA_NAMESPACE }}
553550
CONTROLLER_INSTANCE: ${{ env.WVA_NAMESPACE }}

deploy/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ CONTROLLER_INSTANCE=${CONTROLLER_INSTANCE:-""}
4747
# llm-d Configuration
4848
LLM_D_OWNER=${LLM_D_OWNER:-"llm-d"}
4949
LLM_D_PROJECT=${LLM_D_PROJECT:-"llm-d"}
50-
LLM_D_RELEASE=${LLM_D_RELEASE:-"v0.3.0"}
50+
LLM_D_RELEASE=${LLM_D_RELEASE:-"main"}
5151
LLM_D_MODELSERVICE_NAME=${LLM_D_MODELSERVICE_NAME:-"ms-$WELL_LIT_PATH_NAME-llm-d-modelservice"}
5252
LLM_D_EPP_NAME=${LLM_D_EPP_NAME:-"gaie-$WELL_LIT_PATH_NAME-epp"}
5353
CLIENT_PREREQ_DIR=${CLIENT_PREREQ_DIR:-"$WVA_PROJECT/$LLM_D_PROJECT/guides/prereq/client-setup"}

0 commit comments

Comments
 (0)