Bug fix: Fix LearnedParameters race condition (#943)

* Add shuynh2017 to the OWNERS list

* Bug fix: fix LearnedParameters race condition

Author: shuynh2017

Makefile

@@ -91,7 +91,7 @@ vet: ## Run go vet against code.
 
 .PHONY: test
 test: manifests generate fmt vet setup-envtest helm ## Run tests.
-	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" PATH=$(LOCALBIN):$(PATH) go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out
+	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" PATH="$(LOCALBIN):$(PATH)" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out
 
 # Creates a multi-node Kind cluster
 # Adds emulated GPU labels and capacities per node

internal/engines/analyzers/queueingmodel/parameters.go

@@ -24,19 +24,52 @@ type LearnedParameters struct {
 	LastUpdated time.Time
 }
 
+// DeepCopy creates a deep copy of LearnedParameters
+func (lp *LearnedParameters) deepCopy() *LearnedParameters {
+	if lp == nil {
+		return nil
+	}
+
+	copied := &LearnedParameters{
+		Alpha:       lp.Alpha,
+		Beta:        lp.Beta,
+		Gamma:       lp.Gamma,
+		NIS:         lp.NIS,
+		LastUpdated: lp.LastUpdated,
+	}
+
+	// Deep copy the Covariance matrix
+	if lp.Covariance != nil {
+		copied.Covariance = make([][]float64, len(lp.Covariance))
+		for i := range lp.Covariance {
+			if lp.Covariance[i] != nil {
+				copied.Covariance[i] = make([]float64, len(lp.Covariance[i]))
+				copy(copied.Covariance[i], lp.Covariance[i])
+			}
+		}
+	}
+
+	return copied
+}
+
 // NewParameterStore creates a new parameter store
 func NewParameterStore() *ParameterStore {
 	return &ParameterStore{
 		params: make(map[string]*LearnedParameters),
 	}
 }
 
-// Get retrieves parameters for a variant (nil if does not exist)
+// Get retrieves a deep copy of parameters for a variant (nil if does not exist)
 func (s *ParameterStore) Get(namespace, variantName string) *LearnedParameters {
 	s.mu.RLock()
 	defer s.mu.RUnlock()
 	key := makeVariantKey(namespace, variantName)
-	return s.params[key]
+	params := s.params[key]
+	if params == nil {
+		return nil
+	}
+	// Return a deep copy to avoid race conditions on Covariance slice
+	return params.deepCopy()
 }
 
 // Set stores parameters for a variant (overrides any earlier parameters)