Skip to content

Commit 73112cd

Browse files
committed
limiter e2e test fix
1 parent 11c3130 commit 73112cd

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

test/e2e/limiter_test.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ var _ = Describe("GPU Limiter Feature", Label("full"), Ordered, func() {
7171
err = fixtures.EnsureModelService(ctx, k8sClient, cfg.LLMDNamespace, modelServiceB, poolB, cfg.ModelID, cfg.UseSimulator, cfg.MaxNumSeqs)
7272
Expect(err).NotTo(HaveOccurred(), "Failed to create model service B")
7373

74-
err = fixtures.EnsureService(ctx, k8sClient, cfg.LLMDNamespace, modelServiceB, modelServiceB+"-decode", 8001)
74+
err = fixtures.EnsureService(ctx, k8sClient, cfg.LLMDNamespace, modelServiceB, modelServiceB+"-decode", 8000)
7575
Expect(err).NotTo(HaveOccurred(), "Failed to create service B")
7676

7777
By("Creating ServiceMonitor for service B")
@@ -306,7 +306,7 @@ var _ = Describe("GPU Limiter Feature", Label("full"), Ordered, func() {
306306
err := fixtures.CreateLoadJob(ctx, k8sClient, cfg.LLMDNamespace, "limiter-load-a", targetA, loadCfg)
307307
Expect(err).NotTo(HaveOccurred())
308308

309-
targetB := fmt.Sprintf("http://%s-service:8001", modelServiceB)
309+
targetB := fmt.Sprintf("http://%s-service:8000", modelServiceB)
310310
err = fixtures.CreateLoadJob(ctx, k8sClient, cfg.LLMDNamespace, "limiter-load-b", targetB, loadCfg)
311311
Expect(err).NotTo(HaveOccurred())
312312

@@ -335,8 +335,18 @@ var _ = Describe("GPU Limiter Feature", Label("full"), Ordered, func() {
335335
})
336336
})
337337

338-
By("Waiting for VAs to process load")
339-
time.Sleep(2 * time.Minute)
338+
By("Waiting for both load jobs to complete")
339+
Eventually(func(g Gomega) {
340+
jobA, err := k8sClient.BatchV1().Jobs(cfg.LLMDNamespace).Get(ctx, jobNameA, metav1.GetOptions{})
341+
g.Expect(err).NotTo(HaveOccurred())
342+
g.Expect(jobA.Status.Succeeded).To(BeNumerically(">", 0), "Job A should complete successfully")
343+
}, 5*time.Minute, 10*time.Second).Should(Succeed())
344+
345+
Eventually(func(g Gomega) {
346+
jobB, err := k8sClient.BatchV1().Jobs(cfg.LLMDNamespace).Get(ctx, jobNameB, metav1.GetOptions{})
347+
g.Expect(err).NotTo(HaveOccurred())
348+
g.Expect(jobB.Status.Succeeded).To(BeNumerically(">", 0), "Job B should complete successfully")
349+
}, 5*time.Minute, 10*time.Second).Should(Succeed())
340350

341351
By("Verifying both VAs are independently managed")
342352
// Use Eventually to handle transient API connectivity issues (e.g., TLS handshake timeouts)

0 commit comments

Comments
 (0)