Skip to content

Commit aa7e6d2

Browse files
Fix: Set Metrics: metricsserver.Options{BindAddress: 0} to disable the metrics server in tests, since it's not needed for indexer testing. (#976)
Signed-off-by: greg pereira <grpereir@redhat.com>
1 parent 96c7e55 commit aa7e6d2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

internal/controller/indexers/indexers_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2828
"sigs.k8s.io/controller-runtime/pkg/client"
2929
"sigs.k8s.io/controller-runtime/pkg/manager"
30+
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
3031

3132
llmdv1alpha1 "github.com/llm-d/llm-d-workload-variant-autoscaler/api/v1alpha1"
3233
"github.com/llm-d/llm-d-workload-variant-autoscaler/internal/constants"
@@ -55,7 +56,9 @@ var _ = Describe("Indexers", Ordered, func() {
5556

5657
// Create a manager with indexes for testing
5758
var err error
58-
mgr, err = manager.New(cfg, manager.Options{})
59+
mgr, err = manager.New(cfg, manager.Options{
60+
Metrics: metricsserver.Options{BindAddress: "0"}, // disable metrics server in tests
61+
})
5962
Expect(err).NotTo(HaveOccurred())
6063

6164
// Setup indexes

0 commit comments

Comments
 (0)